[SWDEV-457354] Fix flang-457354 test case #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 06f775a. It fixes flang-457354 test case.
samjwu
pushed a commit
that referenced
this pull request
Apr 25, 2024
Documentation - Add sphinx configs for Read the Docs/RTD
|
Issue should be fixed on upstream main branch (PR#89776) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables test flang-457354 to run by reverting commit (llvm#81929).
We should not mark functions with the "internal-linkage" attribute if they contain an OpenMP target directive. Assigning the internal linkage attribute to such functions causes them to be optimized out by MLIR optimization passes for the offload MLIR files. Consequently, we do not generate offload kernels.