[MLIR][OpenMP] Support lowering of host_eval to LLVM IR #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatrak
requested review from
ergawy,
jsjodin,
agozillon,
DominikAdamski,
TIFitis,
kparzysz and
bhandarkar-pranav
This patch updates the MLIR to LLVM IR lowering of `omp.target` to support passing `num_teams`, `num_threads`, `thread_limit` and SPMD loop bounds through the `host_eval` argument of `omp.target`. This replaces the previous implementation where this information was directly attached to the `omp.target` operation rather than captured to be used by the corresponding nested operation.
skatrak
force-pushed
the
users/skatrak/target-passthrough-02-mlir
branch
from
44b6230
to
719e50c
Compare
skatrak
force-pushed
the
users/skatrak/target-passthrough-03-mlir-llvm
branch
from
e2ee789
to
a9a83c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the MLIR to LLVM IR lowering of
omp.targetto support passingnum_teams,num_threads,thread_limitand SPMD loop bounds through thehost_evalargument ofomp.target.This replaces the previous implementation where this information was directly attached to the
omp.targetoperation rather than captured to be used by the corresponding nested operation.The implementation of
TargetOp::getInnermostCapturedOmpOpis also improved to address bugs in the detection of target SPMD in MLIR, uncovered by changes to the translation to LLVM IR.