Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable building with CCE #212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

enable building with CCE #212

wants to merge 1 commit into from

Conversation

JorgeG94
Copy link

I had to unset a variable in order for the code to build with CCE otherwise I could not build.

@JorgeG94 JorgeG94 requested a review from cgmb as a code owner December 11, 2024 21:54
@cgmb
Copy link
Collaborator

cgmb commented Jan 7, 2025

Thanks for the contribution. The SET_COMPILE_FLAG function does seem to be a pain point for supporting alternative compilers. I suspect that your change may have side-effects that would negatively affect the builds for other compilers, but I don't fully understand the surrounding code so I cannot say for sure yet. Once I understand the surrounding context, I'll give you a firm thumbs up or thumbs down on merging this PR.

@bcornille
Copy link
Contributor

It may be worthwhile to borrow the design of blt_append_custom_compiler_flag to make SET_COMPILER_FLAG more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants