Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Major Contraction #279

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Column Major Contraction #279

wants to merge 5 commits into from

Conversation

dlangbe
Copy link
Collaborator

@dlangbe dlangbe commented Oct 14, 2024

Default to using HIPTENSOR_DATA_LAYOUT_COL_MAJOR when constructing strides in hiptensorInitTensorDescriptor when no strides are specified by user. HIPTENSOR_DATA_LAYOUT_COL_MAJOR can be specified by user when configuring CMake project.

CongMa13
CongMa13 previously approved these changes Oct 17, 2024
Copy link
Collaborator

@CongMa13 CongMa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

cgmillette
cgmillette previously approved these changes Oct 18, 2024
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the fix in now, but must remember to cherry pick for 6.3 with the A/C run.

@dlangbe dlangbe dismissed stale reviews from CongMa13 and cgmillette via 1b945ba October 29, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants