Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex f32 f64 (release-staging/rocm-rel-6.1) #175

Merged

Commits on Nov 30, 2023

  1. Bump rocm-docs-core from 0.28.0 to 0.30.0 in /docs/.sphinx

    Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.28.0 to 0.30.0.
    - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
    - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
    - [Commits](ROCm/rocm-docs-core@v0.28.0...v0.30.0)
    
    ---
    updated-dependencies:
    - dependency-name: rocm-docs-core
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1f69024 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge pull request ROCm#161 from ROCmSoftwarePlatform/dependabot/pip/…

    …docs/dot-sphinx/rocm-docs-core-0.30.0
    
    Bump rocm-docs-core from 0.28.0 to 0.30.0 in /docs/.sphinx
    cgmillette authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d71dcad View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Rename sample of permutation

    Rename `permutation` to `simple_permutation` to comply with naming
    conventions.
    CongMa13 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    fc450d9 View commit details
    Browse the repository at this point in the history
  2. Add unittest to for the permute CPU implementation

    - compare the permute result with reference
    - test col/row major
    - test float and _Float16
    CongMa13 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    9c4c762 View commit details
    Browse the repository at this point in the history
  3. Bump gitpython from 3.1.35 to 3.1.37 in /docs/.sphinx

    Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.35 to 3.1.37.
    - [Release notes](https://github.com/gitpython-developers/GitPython/releases)
    - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
    - [Commits](gitpython-developers/GitPython@3.1.35...3.1.37)
    
    ---
    updated-dependencies:
    - dependency-name: gitpython
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bba3217 View commit details
    Browse the repository at this point in the history
  4. Bump urllib3 from 1.26.15 to 1.26.18 in /docs/.sphinx

    Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.15 to 1.26.18.
    - [Release notes](https://github.com/urllib3/urllib3/releases)
    - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
    - [Commits](urllib3/urllib3@1.26.15...1.26.18)
    
    ---
    updated-dependencies:
    - dependency-name: urllib3
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3f7a904 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Bump rocm-docs-core from 0.30.0 to 0.30.1 in /docs/.sphinx

    Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.30.0 to 0.30.1.
    - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
    - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
    - [Commits](ROCm/rocm-docs-core@v0.30.0...v0.30.1)
    
    ---
    updated-dependencies:
    - dependency-name: rocm-docs-core
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    23b46d6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ROCm#156 from CongMa13/permute_cpu_unit_test

    Add unittest to for the permute CPU implementation
    CongMa13 authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0be15e6 View commit details
    Browse the repository at this point in the history
  3. Fix spelling in documentation (ROCm#155)

    * Fix spelling in documentation
    
    * Use code directive to escape code keywords
    
    * Revert "Use code directive to escape code keywords"
    
    This reverts commit 7be7e34.
    
    * Disable spellcheck on API Reference Guide
    
    * Fix spelling in API Reference Guide
    
    hiptensor > hipTensor
    samjwu authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    852992e View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Add support to f16 and bf16 to contraction

    - Support _Float16
    - Support hip_bfloat16
    - Add unit test of _Float16 and hip_bfloat16
    - Add sample of _Float16 and hip_bfloat16
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c5fbcec View commit details
    Browse the repository at this point in the history
  2. Add support to f32_f16, f32_bf16, f64_f32 to contraction

    - Support ABCD data type f32 and compute type f16, bf16
    - Support ABCD data type f64 and compute type f32
    - Fixed bug: alpha, beta were passed in as wrong data type in unit test
    of contraction
    - Create sample template of contraction
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    185a2ab View commit details
    Browse the repository at this point in the history
  3. Add placeholder for solution unique_id

    Solution unique_ids of Actor Critic are have not been ready yet, but we
    put some placeholders in the new Actor Critic to make the unit tests be
    able to pass.
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ab8d557 View commit details
    Browse the repository at this point in the history
  4. Update contraction device instances

    Update contraction device instances since CK has updated them.
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    df27e32 View commit details
    Browse the repository at this point in the history
  5. Print C in sample output

    1. Initiate the data with 0.01, 0.02, ... by default
    2. Print C
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f85df83 View commit details
    Browse the repository at this point in the history
  6. Set CK contraction instance only run once

    When logger level is set to HIPTENSOR_LOG_LEVEL_PERF_TRACE, we make CK
    instances measure the running time. The problem is that CK internally
    will run the contraction 10 times by default. This leads to an issues:
    
    1. It returns wrong result for C = alpha A x B + beta C
    
    Set StreamConfig.nrepeat_ = 1, the contraction will be run once
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5c45a8c View commit details
    Browse the repository at this point in the history
  7. Fixed a bug in CPU reference

    1. ck::bhalf_t cannot cast to float or double by static_cast.
    Use ck::type_convert() to fix it.
    
    2. epsilon() is not good value to measure the relative difference of
    data. It is too small for double (eps < 10e-13).
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f631818 View commit details
    Browse the repository at this point in the history
  8. Add commnets

    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    e5cefe7 View commit details
    Browse the repository at this point in the history
  9. Rename contraction sameple files

    The pattern of contraction sameple file is
    
    - bilinear: simple_bilinear_contraction_<A>_<B>_<C>_<D>_compute_<compute>.cpp
    - scale   : simple_scale_contraction_<A>_<B>_<C>_compute_<compute>.cpp
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4345a1c View commit details
    Browse the repository at this point in the history
  10. Improve CPU reference accurary

    The relative difference between contraction result and CPU reference is
    less than 0.1% after the improvement.
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    43f33ee View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fec9065 View commit details
    Browse the repository at this point in the history
  12. Update CPU reference

    1. Revert the default threshold of relative difference to (100 * std::numeric_limits<T>::epsilon())
    2. Update CPU reference to make the difference between CPU reference and output of contraction instance
    is less than (100 * std::numeric_limits<T>::epsilon()).
    CongMa13 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b21fe0b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge pull request ROCm#158 from CongMa13/contraction_f16_bf16

    Contraction f16, bf16, f32_f16, f32_bf16, f64_f32
    CongMa13 authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    8c11d59 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76de7d0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request ROCm#166 from ROCm/dependabot/pip/docs/dot-sphinx/…

    …rocm-docs-core-0.30.1
    
    Bump rocm-docs-core from 0.30.0 to 0.30.1 in /docs/.sphinx
    cgmillette authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    71ae65d View commit details
    Browse the repository at this point in the history
  4. Merge pull request ROCm#164 from ROCm/dependabot/pip/docs/dot-sphinx/…

    …urllib3-1.26.18
    
    Bump urllib3 from 1.26.15 to 1.26.18 in /docs/.sphinx
    cgmillette authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    1dfaea7 View commit details
    Browse the repository at this point in the history
  5. Merge pull request ROCm#163 from ROCm/dependabot/pip/docs/dot-sphinx/…

    …gitpython-3.1.37
    
    Bump gitpython from 3.1.35 to 3.1.37 in /docs/.sphinx
    cgmillette authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b88175f View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge pull request ROCm#169 from CongMa13/remove_xfloat32

    Remove xfloat32 which is not used in hiptensor
    CongMa13 authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    53d687b View commit details
    Browse the repository at this point in the history
  2. fix build warnings

    removed double std namespaces
    fix underlines
    parbenc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    28fe756 View commit details
    Browse the repository at this point in the history
  3. update doxyfile

    parbenc committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c18335a View commit details
    Browse the repository at this point in the history
  4. Bump cryptography from 41.0.4 to 41.0.6 in /docs/.sphinx (ROCm#162)

    Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.4 to 41.0.6.
    - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
    - [Commits](pyca/cryptography@41.0.4...41.0.6)
    
    ---
    updated-dependencies:
    - dependency-name: cryptography
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7ac3fb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    b03e4f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. remove unnecessary endcond

    parbenc committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ded69b9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ROCm#160 from StreamHPC/docs_fix

    Fix docs build error and warnings
    neon60 authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    bcd81bd View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Bump rocm-docs-core from 0.30.1 to 0.30.2 in /docs/.sphinx (ROCm#171)

    Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.30.1 to 0.30.2.
    - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
    - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
    - [Commits](ROCm/rocm-docs-core@v0.30.1...v0.30.2)
    
    ---
    updated-dependencies:
    - dependency-name: rocm-docs-core
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0b34d47 View commit details
    Browse the repository at this point in the history
  2. Bump rocm-docs-core from 0.30.2 to 0.30.3 in /docs/.sphinx

    Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.30.2 to 0.30.3.
    - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
    - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
    - [Commits](ROCm/rocm-docs-core@v0.30.2...v0.30.3)
    
    ---
    updated-dependencies:
    - dependency-name: rocm-docs-core
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    95af3c1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request ROCm#173 from ROCm/dependabot/pip/docs/dot-sphinx/…

    …rocm-docs-core-0.30.3
    
    Bump rocm-docs-core from 0.30.2 to 0.30.3 in /docs/.sphinx
    cgmillette authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f5803f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Configuration menu
    Copy the full SHA
    e41eda6 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Add API changes

    - Add API changes
    - Add test files
    - Add samples
    - Add cpu contraction for complex types
    - Add complex instances
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7496442 View commit details
    Browse the repository at this point in the history
  2. Add compute types

    - Add compute types
    - Add instance factory for scale
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    be8c0b5 View commit details
    Browse the repository at this point in the history
  3. Modify instance factory

    - Modify complex scale impl
    - Modify pack func
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f6e39c1 View commit details
    Browse the repository at this point in the history
  4. Enable complex f32

    - Remove intermediate buffers
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    075cdfa View commit details
    Browse the repository at this point in the history
  5. Add scalar and complex type instances

    - Add cpu instances
    - Add scale complex initial imp
    - Remove compute f32 instances for complex f32
    - Modify multiply utility
    - Modified bilinear to take complex compute
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1bf4a55 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b50a159 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b85aa93 View commit details
    Browse the repository at this point in the history
  8. Modify base class compute type

    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1b2031e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    41c44b2 View commit details
    Browse the repository at this point in the history
  10. Add unit test of contraction with complex compute type

    - Fix issue in yaml_test
    - Fix a bug in hiptensorInitContractionDescriptor
    CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    cf233d8 View commit details
    Browse the repository at this point in the history
  11. Modify samples to use new compute type

    - Fix bug in samples
    - Add unit tests for scale contraction
    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    c01eda7 View commit details
    Browse the repository at this point in the history
  12. Support Complex alpha and beta in samples

    - Add complex_scale_contraction_test.cpp
    - Fixed bug in device_contraction_bilinear_complex.hpp
    CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    23c033f View commit details
    Browse the repository at this point in the history
  13. Cleanup

    mkarunan authored and CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    48abe4a View commit details
    Browse the repository at this point in the history
  14. Set unit test difference threshold to epsilon of compute type

    - New single kernel selection. To be improved.
    - Used instance selected by brute force to compute tensor with 1 as the
    most right stride
    - Fixed bug that used data type id as compute data type id
    CongMa13 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    348e281 View commit details
    Browse the repository at this point in the history