Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in documentation #155

Merged
merged 5 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/API_Reference_Guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,16 @@
Introduction
************

hiptensor Data Types
hipTensor Data Types
====================

samjwu marked this conversation as resolved.
Show resolved Hide resolved
.. <!-- spellcheck-disable -->

hiptensorStatus_t
-----------------

.. doxygenenum:: hiptensorStatus_t


hiptensorComputeType_t
----------------------

Expand Down Expand Up @@ -160,3 +161,5 @@ hiptensorLoggerForceDisable
---------------------------

.. doxygenfunction:: hiptensorLoggerForceDisable
samjwu marked this conversation as resolved.
Show resolved Hide resolved

.. <!-- spellcheck-enable -->
25 changes: 12 additions & 13 deletions docs/Contributors_Guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ License Agreement
Pull-request guidelines
=======================


Our code contriubtion guidelines closely follows the model of `GitHub
Our code contribution guidelines closely follows the model of `GitHub
pull-requests <https://help.github.com/articles/using-pull-requests/>`__.
The hipTensor repository follows a workflow which dictates a /master branch where releases are cut, and a
/develop branch which serves as an integration branch for new code. Pull requests should:
Expand All @@ -30,7 +29,7 @@ The hipTensor repository follows a workflow which dictates a /master branch wher
- code must also have benchmark tests, and performance must approach
the compute bound limit or memory bound limit.

StyleGuide
Style Guide
==========

This project follows the `CPP Core
Expand All @@ -44,16 +43,16 @@ Interface
---------

- Library code should use C++17
- Avoid CamelCase
- Avoid Camel case
- This rule applies specifically to publicly visible APIs, but is also
encouraged (not mandated) for internal code

Philosophy
----------

- `P.2 <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rp-Cplusplus>`__:
Write in ISO Standard C++14 (especially to support windows, linux and
macos plaforms )
Write in ISO Standard C++14 (especially to support Windows, Linux and
macOS platforms )
- `P.5 <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rp-compile-time>`__:
Prefer compile-time checking to run-time checking

Expand Down Expand Up @@ -105,19 +104,19 @@ will result in different results.

To format a file, use:

::
.. code-block::

/opt/rocm/llvm/bin/clang-format -style=file -i <path-to-source-file>
/opt/rocm/llvm/bin/clang-format -style=file -i <path-to-source-file>

To format all files, run the following script in hipTensor directory:

::
.. code-block::

#!/bin/bash
git ls-files -z *.cc *.cpp *.h *.hpp *.cl *.h.in *.hpp.in *.cpp.in | xargs -0 /opt/rocm/llvm/bin/clang-format -style=file -i
#!/bin/bash
git ls-files -z *.cc *.cpp *.h *.hpp *.cl *.h.in *.hpp.in *.cpp.in | xargs -0 /opt/rocm/llvm/bin/clang-format -style=file -i

Also, githooks can be installed to format the code per-commit:

::
.. code-block::

./.githooks/install
./.githooks/install
29 changes: 15 additions & 14 deletions docs/Linux_Install_Guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ Minimum ROCm version support is 5.7.

By default, the project is configured as Release mode.

To build only library, run the following comomand :
To build only library, run the following command :

CC=hipcc CXX=hipcc cmake -B<build_dir> . -DHIPTENSOR_BUILD_TESTS=OFF -DHIPTENSOR_BUILD_SAMPLES=OFF
:code:`CC=hipcc CXX=hipcc cmake -B<build_dir> . -DHIPTENSOR_BUILD_TESTS=OFF -DHIPTENSOR_BUILD_SAMPLES=OFF`

Here are some other example project configurations:

Expand All @@ -116,30 +116,30 @@ Here are some other example project configurations:
+-----------------------------------+--------------------------------------------------------------------------------------------------------------------+
| Configuration | Command |
+===================================+====================================================================================================================+
| Basic | CC=hipcc CXX=hipcc cmake -B<build_dir> . |
| Basic | :code:`CC=hipcc CXX=hipcc cmake -B<build_dir> .` |
+-----------------------------------+--------------------------------------------------------------------------------------------------------------------+
| Targeting gfx908 | CC=hipcc CXX=hipcc cmake -B<build_dir> . -DAMDGPU_TARGETS=gfx908:xnack- |
| Targeting gfx908 | :code:`CC=hipcc CXX=hipcc cmake -B<build_dir> . -DAMDGPU_TARGETS=gfx908:xnack-` |
+-----------------------------------+--------------------------------------------------------------------------------------------------------------------+
| Debug build | CC=hipcc CXX=hipcc cmake -B<build_dir> . -DCMAKE_BUILD_TYPE=Debug |
| Debug build | :code:`CC=hipcc CXX=hipcc cmake -B<build_dir> . -DCMAKE_BUILD_TYPE=Debug` |
+-----------------------------------+--------------------------------------------------------------------------------------------------------------------+

After configuration, build with

cmake --build <build_dir> -- -j
:code:`cmake --build <build_dir> -- -j`


Build library + samples
^^^^^^^^^^^^^^^^^^^^^^^

To build library and samples, run the following comomand :
To build library and samples, run the following command:

CC=hipcc CXX=hipcc cmake -B<build_dir> . -DHIPTENSOR_BUILD_TESTS=OFF -DHIPTENSOR_BUILD_SAMPLES=ON
:code:`CC=hipcc CXX=hipcc cmake -B<build_dir> . -DHIPTENSOR_BUILD_TESTS=OFF -DHIPTENSOR_BUILD_SAMPLES=ON`

After configuration, build with

cmake --build <build_dir> -- -j
:code:`cmake --build <build_dir> -- -j`

The samples folder in <build_dir> contains executables in the table below.
The samples folder in :code:`<build_dir>` contains executables in the table below.

=================================== ===================================================================================
executable name description
Expand All @@ -154,13 +154,13 @@ Build library + tests

To build library and tests, run the following command :

CC=hipcc CXX=hipcc cmake -B<build_dir> .
:code:`CC=hipcc CXX=hipcc cmake -B<build_dir> .`

After configuration, build with

cmake --build <build_dir> -- -j
:code:`cmake --build <build_dir> -- -j`

The tests in <build_dir> contains executables in the table below.
The tests in `<build_dir>` contains executables in the table below.

====================================== ===================================================================================
executable name description
Expand All @@ -177,6 +177,7 @@ Build library + Documentation

Run the steps below to build documentation locally.

.. code-block::
cd docs

sudo apt-get update
Expand All @@ -191,4 +192,4 @@ Run the steps below to build documentation locally.

pdflatex hiptensor.tex

Generates hiptensor.pdf here
Generates :code:`hiptensor.pdf` here
39 changes: 19 additions & 20 deletions docs/Programmers_Guide.rst
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

===================
Programmer's Guide
===================
Expand All @@ -17,84 +16,84 @@ The hipTensor code is split into four major parts:
The `library` directory
^^^^^^^^^^^^^^^^^^^^^^^

library/include/hiptensor/
`library/include/hiptensor/`
'''''''''''''''''''''''''''

Contains C++ include files for the hipTensor API. These files also contain Doxygen
comments that document the API.

library/include/hiptensor/internal
`library/include/hiptensor/internal`
''''''''''''''''''''''''''''''''''

Internal include files for:

- Utility Code
- Generate Tensor Utility

library/src/
`library/src/`
''''''''''''

Contains logger, device and performance functions.

library/src/contraction/
`library/src/contraction/`
''''''''''''''''''''''''

Contains hipTensor core composable kernel header functions and contraction initialization functions.

library/src/contraction/device
`library/src/contraction/device`
''''''''''''''''''''''''''''''

Contains hipTensor Bilinear and Scale instance functions

The `samples` directory
^^^^^^^^^^^^^^^^^^^^^^^
01_contraction/simple_bilinear_contraction_f32.cpp
`01_contraction/simple_bilinear_contraction_f32.cpp`
''''''''''''''''''''''''''''''''''''''''''''''''''

sample code for calling bilinear contraction for fp32 input, output and compute types
sample code for calling bilinear contraction for :code:`fp32` input, output and compute types


01_contraction/simple_scale_contraction_f32.cpp
`01_contraction/simple_scale_contraction_f32.cpp`
'''''''''''''''''''''''''''''''''''''''''''''''

sample code for calling scale contraction for fp32 input, output and compute types
sample code for calling scale contraction for :code:`fp32` input, output and compute types

The `test` directory
^^^^^^^^^^^^^^^^^^^^^^^

00_unit/logger
`00_unit/logger`
''''''''''''''

Test code for testing logger API Functions of hipTensor

01_contraction/bilinear_contraction_f32
`01_contraction/bilinear_contraction_f32`
'''''''''''''''''''''''''''''''''''''''

Test code for testing the bilinear contraction functionality and log metrics for F32 types.

01_contraction/bilinear_contraction_f64
`01_contraction/bilinear_contraction_f64`
'''''''''''''''''''''''''''''''''''''''

Test code for testing the bilinear contraction functionality and log metrics for F64 types.

01_contraction/scale_contraction_f32
`01_contraction/scale_contraction_f32`
''''''''''''''''''''''''''''''''''''

Test code for testing the scale contraction functionality and log metrics for F32 types.

01_contraction/scale_contraction_f64
`01_contraction/scale_contraction_f64`
''''''''''''''''''''''''''''''''''''

Test code for testing the scale contraction functionality and log metrics for F64 types.

Infrastructure
^^^^^^^^^^^^^^

- CMake is used to build and package hipTensor. There are CMakeLists.txt files throughout the code.
- Doxygen/Breathe/Sphinx/ReadTheDocs are used to produce documentation. Content for the documentation is from:
- CMake is used to build and package hipTensor. There are :code:`CMakeLists.txt` files throughout the code.
- `Doxygen/Breathe/Sphinx/ReadtheDocs` are used to produce documentation. Content for the documentation is from:

- Doxygen comments in include files in the directory library/include
- files in the directory docs/
- Doxygen comments in include files in the directory :code:`library/include`
- files in the directory :code:`docs/`

- Jenkins is used to automate Continuous Integration testing.
- clang-format is used to format C++ code.
- :code:`clang-format` is used to format C++ code.
4 changes: 2 additions & 2 deletions docs/index.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
============================================================================
hiptensor: A High-Performance HIP Library For Tensor Primitives
hipTensor: A High-Performance HIP Library For Tensor Primitives
============================================================================

hiptensor is AMD's C++ library for accelerating tensor primitives based on the
hipTensor is AMD's C++ library for accelerating tensor primitives based on the
composable kernel library, through general purpose kernel languages, like HIP C++.