Use split CK libraries. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illsilin
requested review from
cgmillette,
bragadeesh,
mkarunan,
dlangbe,
CongMa13 and
afanfa
as code owners
cgmillette
approved these changes
Nov 15, 2023
dlangbe
approved these changes
Nov 15, 2023
|
Hi @illsilin , are these changes merged upstream in CK? |
|
Hi @cgmillette, I was asked to update the version number for these changes in CK. |
|
Hi @cgmillette. The changes in CK have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow using the split static libraries in CK, when instead of single libdevice_operations.a file, we can use a separate file for each operation type, e.g., device_contraction_operations, device_gemm_operations, etc.
This PR should be synchronized with the PR merge into CK and MIOpen.