Add -std=c++11 flag to tests that need it, compiler should not set th… #105
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is flag itself - gerrit review
ronlieb
requested review from
gregrodgers,
jsjodin,
JonChesterfield,
estewart08,
richardbleikamp and
scchan
JonChesterfield
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is flag itself - gerrit review
Review feedback from patch #6 http://gerrit-git.amd.com/c/lightning/ec/llvm-project/+/358446 observed that AOMP added flagsg -std=c++11 explicitly and to compiles and should not do this. Users/tests should request the proper c++ support flag when warranted.
i have modified all the smoke and hip tests that need to explicitly set the flag .