Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential bug in
tools/prerpocess_data.py
.Bookcorpus preprocessing fails under certain conditions when using rocm/pytorch-training:v25.2 image and installing Megatron-LM with
pip install .
from the latest ROCm/Megatron-LM rocm_dev branch. Withand running
only executes sentence splitting while doing the same with
--partitions 2
runs both sentence splitting and tokenization. Furthermore, running the above with--partitions 1
twice should also be a work-around since then split-sentence data is available in the second go.Proposed solution is to remove 2 lines in
tools/preprocess_data.py
.