Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests rocm #12

Merged
merged 5 commits into from
Nov 7, 2024
Merged

unit tests rocm #12

merged 5 commits into from
Nov 7, 2024

Conversation

gurpreet-dhami
Copy link
Collaborator

  • Added marker "@pytest.mark.failing_on_rocm" for all failing tests on rocm.

test_report_pytests.csv
unit_test_logs.txt

------------------------- CSV report: test_report.csv --------------------------
305 passed, 18 skipped, 270 deselected, 955 warnings in 160.58s (0:02:40) ===

  • Total tests skipped for ROCM
    114 out of 593

@gurpreet-dhami gurpreet-dhami force-pushed the unit_tests_rocm branch 2 times, most recently from c390b79 to cee8a2b Compare November 6, 2024 04:14
@gurpreet-dhami gurpreet-dhami changed the title markers for failing tests on rocm unit tests rocm Nov 6, 2024
@gurpreet-dhami gurpreet-dhami force-pushed the unit_tests_rocm branch 7 times, most recently from 3518f1a to e374d4d Compare November 6, 2024 18:46
Jenkinsfile Outdated
}
stage('Test') {

stage('Run Docker Container') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably re-name it as "Run unit-tests"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcskrishna : done.

@lcskrishna
Copy link
Collaborator

Minor comments, otherwise looks good to me.

Dockerfile_rocm_ci Outdated Show resolved Hide resolved
Copy link
Collaborator

@wenchenvincent wenchenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address the comments?

@gurpreet-dhami gurpreet-dhami merged commit 399c8d9 into rocm_dev Nov 7, 2024
1 check was pending
@gurpreet-dhami gurpreet-dhami deleted the unit_tests_rocm branch November 7, 2024 22:43
@gurpreet-dhami gurpreet-dhami restored the unit_tests_rocm branch November 7, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants