Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[igemm] fix xdlop wrw padding kernel #563

Closed
wants to merge 1 commit into from
Closed

Conversation

asleepzzz
Copy link
Contributor

fix
./bin/MIOpenDriver conv -F 4 -n 120 -c 510 -H 5 -W 5 -k 250 -y 3 -x 3 -p 1 -q 1 -u 1 -v 1 -l 1 -j 1 -g 1 -t 1
this patch is not fixing nan issue

@daniellowell
Copy link
Contributor

Then what does it do?

@asroy
Copy link
Contributor

asroy commented Nov 2, 2020

Then what does it do?

It fix an issue uncovered when testing http://ontrack-internal.amd.com/browse/SWDEV-258337

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #563 into develop will decrease coverage by 0.02%.
The diff coverage is 31.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
- Coverage    52.20%   52.18%   -0.03%     
===========================================
  Files          297      298       +1     
  Lines        46061    46046      -15     
===========================================
- Hits         24047    24028      -19     
- Misses       22014    22018       +4     
Impacted Files Coverage Δ
src/include/miopen/conv/asm_implicit_gemm.hpp 0.00% <0.00%> (ø)
src/include/miopen/generic_search.hpp 0.00% <0.00%> (ø)
src/include/miopen/solver.hpp 15.08% <ø> (+1.03%) ⬆️
..._hip_implicit_gemm_wrw_v4r4_xdlops_padded_gemm.cpp 0.52% <0.00%> (ø)
src/solver/conv_multipass_wino3x3WrW.cpp 2.12% <ø> (ø)
test/conv_common.hpp 60.18% <ø> (ø)
.../conv_asm_implicit_gemm_wrw_gtc_dynamic_xdlops.cpp 1.47% <1.92%> (ø)
src/solver/conv_asm_implicit_gemm_gtc_bwd.cpp 3.41% <2.00%> (-0.09%) ⬇️
src/solver/conv_asm_implicit_gemm_gtc_fwd.cpp 4.76% <3.33%> (+0.11%) ⬆️
src/ocl/convolutionocl.cpp 58.39% <66.66%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3aa3d...2950bdc. Read the comment docs.

@asroy
Copy link
Contributor

asroy commented Nov 5, 2020

#568 should be able fix the issue, so this PR is no longer needed

@asroy asroy closed this Nov 5, 2020
@junliume junliume deleted the wrw_padding_fix branch July 20, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants