Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace [[gnu::noreturn]] with [[noreturn]] #2656

Merged
merged 1 commit into from
Jan 14, 2024
Merged

replace [[gnu::noreturn]] with [[noreturn]] #2656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addkernels/addkernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ void PrintHelp()
<< std::endl;
}

[[gnu::noreturn]] void WrongUsage(const std::string& error)
[[noreturn]] void WrongUsage(const std::string& error)
{
std::cout << "Wrong usage: " << error << std::endl;
std::cout << std::endl;
Expand All @@ -117,7 +117,7 @@ void PrintHelp()
std::exit(1);
}

[[gnu::noreturn]] void UnknownArgument(const std::string& arg)
[[noreturn]] void UnknownArgument(const std::string& arg)
{
std::ostringstream ss;
ss << "unknown argument - " << arg;
Expand Down
2 changes: 1 addition & 1 deletion driver/InputFlags.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ void InputFlags::AddTensorFlag(const std::string& name,
AddInputFlag(name, short_name, default_value, desc.str(), "tensor descriptor");
}

[[gnu::noreturn]] void InputFlags::Print() const
void InputFlags::Print() const
{
printf("MIOpen Driver Input Flags: \n\n");

Expand Down
2 changes: 1 addition & 1 deletion driver/InputFlags.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class InputFlags

void Parse(int argc, char* argv[]);
char FindShortName(const std::string& _long_name) const;
void Print() const;
[[noreturn]] void Print() const;

std::string GetValueStr(const std::string& _long_name) const;
int GetValueInt(const std::string& _long_name) const;
Expand Down
2 changes: 1 addition & 1 deletion driver/driver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ inline void PadBufferSize(size_t& sz, int datatype_sz)
}
}

[[gnu::noreturn]] inline void Usage()
[[noreturn]] inline void Usage()
{
printf("Usage: ./driver *base_arg* *other_args*\n");
printf("Supported Base Arguments: conv[fp16|int8|bfp16|fp8|bfp8], CBAInfer[fp16], "
Expand Down
2 changes: 1 addition & 1 deletion test/test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ inline void failed(const char* msg, const char* file, int line)
std::cout << ss.str();
}

[[gnu::noreturn]] inline void failed_abort(const char* msg, const char* file, int line)
[[noreturn]] inline void failed_abort(const char* msg, const char* file, int line)
{
failed(msg, file, line);
std::abort();
Expand Down