Update the SyncDB tests to use multi-threading #2407
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -251,6 +251,7 @@ def buildHipClangJob(Map conf=[:]){ | |
|
|
||
| def codecov = conf.get("codecov", false) | ||
| def needs_gpu = conf.get("needs_gpu", true) | ||
| def lfs_pull = conf.get("lfs_pull", false) | ||
|
|
||
| def retimage | ||
| gitStatusWrapper(credentialsId: "${env.status_wrapper_creds}", gitHubContext: "Jenkins - ${variant}", account: 'ROCmSoftwarePlatform', repo: 'MIOpen') { | ||
|
|
@@ -284,6 +285,10 @@ def buildHipClangJob(Map conf=[:]){ | |
| withDockerContainer(image: image, args: dockerOpts + ' -v=/var/jenkins/:/var/jenkins') { | ||
| timeout(time: 150, unit:'MINUTES') | ||
| { | ||
| if (lfs_pull) { | ||
| sh "git lfs pull --exclude=" | ||
| } | ||
|
|
||
| cmake_build(conf) | ||
|
|
||
| if (codecov) { | ||
|
|
@@ -586,27 +591,7 @@ pipeline { | |
| | xargs -n 1 -P 1 -I{} -t sh -c \'clang-format-12 -style=file {} | diff - {}\'" | ||
| } | ||
| steps{ | ||
| buildHipClangJobAndReboot(setup_cmd: "", build_cmd: "", execute_cmd: execute_cmd, needs_gpu:false, needs_reboot:false) | ||
| } | ||
| } | ||
| stage('HipNoGPU Debug Build Test') { | ||
|
|
@@ -623,6 +608,15 @@ pipeline { | |
| buildHipClangJob( build_type: 'debug', setup_flags: HipNoGPU_flags, build_cmd: build_cmd, needs_gpu:false, needs_reboot:false) | ||
| } | ||
| } | ||
| stage('Tuna Fin Build Test') { | ||
| agent{ label rocmnode("nogpu") } | ||
| environment{ | ||
| fin_flags = "-DMIOPEN_BACKEND=HIPNOGPU" | ||
| } | ||
| steps{ | ||
| buildHipClangJobAndReboot(setup_flags: fin_flags, config_targets: "all", build_fin: "ON", needs_gpu:false, needs_reboot:false, build_install: "true") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| stage("Smoke Fp32") { | ||
|
|
@@ -918,6 +912,44 @@ pipeline { | |
| Navi21_build_cmd = "LLVM_PATH=/opt/rocm/llvm CTEST_PARALLEL_LEVEL=2 MIOPEN_CONV_PRECISE_ROCBLAS_TIMING=0 MIOPEN_LOG_LEVEL=5 make -j\$(nproc) check" | ||
| } | ||
| parallel{ | ||
| stage('dbsync gfx908') { | ||
| when { | ||
| beforeAgent true | ||
| expression { params.TARGET_GFX908 } | ||
| } | ||
| options { | ||
| retry(2) | ||
| } | ||
| agent{ label rocmnode("gfx908") } | ||
| environment{ | ||
| setup_flags="-DMIOPEN_TEST_DBSYNC=1" | ||
| config_targets='test_db_sync' | ||
| execute_cmd='./bin/test_db_sync' | ||
|
Comment on lines
+926
to
+927
There was a problem hiding this comment. [formatting] Tabs -> spaces
Comment on lines
+925
to
+927
There was a problem hiding this comment. [Recommandation] @JehandadKhan These variables are used only once, and trivially, like |
||
| } | ||
| steps{ | ||
| buildHipClangJobAndReboot(lfs_pull: true, setup_flags: setup_flags, config_targets: config_targets, execute_cmd: execute_cmd, | ||
| needs_gpu:false, needs_reboot:false, build_install: "true") | ||
|
Comment on lines
+930
to
+931
There was a problem hiding this comment. [Recommendation] I would reformat this like buildHipClangJobAndReboot(lfs_pull: true,
setup_flags: setup_flags,
config_targets: config_targets,
execute_cmd: execute_cmd,
needs_gpu:false,
needs_reboot:false,
build_install: "true") |
||
| } | ||
| } | ||
| stage('dbsync gfx90a') { | ||
| when { | ||
| beforeAgent true | ||
| expression { params.TARGET_GFX90A } | ||
| } | ||
| options { | ||
| retry(2) | ||
| } | ||
| agent{ label rocmnode("gfx90a") } | ||
| environment{ | ||
| setup_flags="-DMIOPEN_TEST_DBSYNC=1" | ||
| config_targets='test_db_sync' | ||
| execute_cmd='./bin/test_db_sync' | ||
|
Comment on lines
+945
to
+946
There was a problem hiding this comment. [formatting] Tabs -> spaces |
||
| } | ||
| steps{ | ||
| buildHipClangJobAndReboot(lfs_pull: true, setup_flags: setup_flags, config_targets: config_targets, execute_cmd: execute_cmd, | ||
| needs_gpu:false, needs_reboot:false, build_install: "true") | ||
|
Comment on lines
+949
to
+950
|
||
| } | ||
| } | ||
| stage('Int8 HIP All Vega20') { | ||
| when { | ||
| beforeAgent true | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git LFS file not shown
Binary file not shown.
Binary file not shown.
Git LFS file not shown
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JehandadKhan What is the purpose of thinks like
and then
What if we'll simply
?