Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache CK convolution kernel objects as shared_ptr in Invoker lambda #2336

Closed
amberhassaan opened this issue Aug 24, 2023 · 1 comment · Fixed by #2379
Closed

Cache CK convolution kernel objects as shared_ptr in Invoker lambda #2336

amberhassaan opened this issue Aug 24, 2023 · 1 comment · Fixed by #2379
Assignees

Comments

@amberhassaan
Copy link
Contributor

CK has a DeviceOpFactory::GetInstances() API used by MIOpen Solvers that returns a vector<unique_ptr<T>, where T is an abstraction for a kernel. unique_ptr<T> makes it uncacheable inside MIOpen's Invoker lambda thus preventing reuse and forcing multiple calls to GetInstances() especially at the time of invoking a kernel.

I will put up a PR that promotes unique_ptr<T> to shared_ptr<T> thus allowing us to cacheable inside MIOpen's Invoker.

@atamazov
Copy link
Contributor

atamazov commented Aug 25, 2023

[Notice] IIUC this ticket is related to all CK solvers where this optimization is possible (see #2305 (comment))

@CAHEK7 CAHEK7 linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants