Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-merge issues of #2125 #2301

Closed
2 tasks done
atamazov opened this issue Aug 7, 2023 · 5 comments
Closed
2 tasks done

Post-merge issues of #2125 #2301

atamazov opened this issue Aug 7, 2023 · 5 comments
Assignees
@amberhassaan @iq136boy
Labels
correctness urgency_high

Comments

@atamazov
Copy link
Contributor

atamazov commented Aug 7, 2023 •
edited
Loading

[Attribution] @junliume @JehandadKhan
@JehandadKhan
Copy link
Collaborator

@amberhassaan Can you please take a look at this issue ? IIUC this should be a two liner fix.

Thanks @atamazov for catching this.

@amberhassaan
Copy link
Contributor

Will put out a fix later today.

@atamazov
Copy link
Contributor Author

atamazov commented Aug 7, 2023

One more bullet (yellow) added.

@amberhassaan amberhassaan mentioned this issue Aug 7, 2023
Merged
@atamazov atamazov changed the title Post-merge issues of #2125 Post-merge issues of #2125 and #2305 Aug 25, 2023
@atamazov
Copy link
Contributor Author

atamazov commented Aug 25, 2023 •
edited
Loading

The topmost comment updated with unresolved comments from #2305 and a new ticket.

@atamazov atamazov changed the title Post-merge issues of #2125 and #2305 Post-merge issues of #2125 Aug 25, 2023
@atamazov
Copy link
Contributor Author

via #2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amberhassaan amberhassaan

@iq136boy iq136boy

Labels
correctness urgency_high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amberhassaan @iq136boy @JehandadKhan @junliume @atamazov