Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY] Question: mismatching info about hipify 6.2.2 release versions support.. #1679

Closed
oscarbg opened this issue Oct 3, 2024 · 1 comment
Closed

[HIPIFY] Question: mismatching info about hipify 6.2.2 release versions support.. #1679

oscarbg opened this issue Oct 3, 2024 · 1 comment
Assignees
@emankov
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@oscarbg
Copy link

oscarbg commented Oct 3, 2024 •
edited
Loading

Problem Description

changelog file (https://github.com/ROCm/HIPIFY/blob/amd-staging/CHANGELOG.md) mentions things like cuDNN 9.3.0 support but :

HIPIFY for ROCm 6.2.2
Additions

    cuDNN 9.3.0 support

Fixes

    Removed some post HIP 6.2 APIs from support
    Added hipification support for HIP functions hipSetValidDevices, hipMemcpy2DArrayToArray, hipMemcpyAtoA, hipMemcpyAtoD, hipMemcpyAtoA, hipMemcpyAtoHAsync, and hipMemcpyHtoAAsync
    Fixed an issue with Skipped some replacements when hipification didn't occur at all

but

https://github.com/ROCm/HIPIFY/releases/tag/rocm-6.2.2

mentions no changes:

HIPIFY code for ROCm 6.2.2 did not change

what is correct?
are 6.2.2 changes delayed to 6.2.3?
thanks..

Operating System

ubu

CPU

ryzen

ROCm Version

No response

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response
@emankov emankov self-assigned this Oct 4, 2024
@emankov emankov changed the title Question: mismatching info about hipify 6.2.2 release versions support.. [HIPIFY] Question: mismatching info about hipify 6.2.2 release versions support.. Oct 4, 2024
@emankov emankov added question Further information is requested documentation Improvements or additions to documentation labels Oct 4, 2024
emankov added a commit to emankov/HIPIFY that referenced this issue Oct 4, 2024
@emankov
[HIPIFY][ROCm#1679][doc][fix] Fix the version in CHANGELOG.md
8257de2 
+ HIPIFY `6.2.2` is unchanged, the Release information is correct.
+ [fix] Changes initially reported for HIPIFY `6.2.2` are going to appear in `6.2.4`.
emankov added a commit that referenced this issue Oct 4, 2024
@emankov
Merge pull request #1681 from emankov/HIPIFY
6b2f06c 
[HIPIFY][#1679][doc][fix] Fix the version in `CHANGELOG.md`
@emankov
Copy link
Collaborator

emankov commented Oct 4, 2024

The 6.2.2 changes are going to appear in 6.2.4. Thanks for your observation. The Changelog is fixed.

@emankov emankov closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarbg @emankov