Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(account, transaction): reconciliation and transaction list #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fres-sudo
Copy link
Contributor

This PR aims to add the possibility to change the total amount of your bank account.

Steps to take a reconciliation:

  • Go to Settings Page
  • Go to Accounts
  • Just change the total amount and click "Update Balance"

By doing those steps, the total amount of your accounts updated and a new transaction "Reconciliation" is being created.

This PR also improve the transaction_list.dart code by using ListView.separatedand ListTile to stick to material widget.

-Closes #197

@fres-sudo fres-sudo force-pushed the feat-reconciliation branch from 1a3025d to 9377024 Compare March 3, 2025 20:50
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I had a brief look at your changes and it's working well. I would add this feature also in account_page.dart for the UI you could do something similar to these screenshots. After this I would also add a Your transactions text before the transaction list to divide more the sections.

Feel free to change the text or how it looks, it's here just to give you an idea 😁

Before tap

Screenshot 2025-03-04 211255

After tap

Screenshot 2025-03-04 211314

@mikev-cw
Copy link
Collaborator

mikev-cw commented Mar 4, 2025

Hello, and thank you for this contribution!! I see that overall the process is working very well!
Just noticed something about the number formatting. Tested only on Android, started from 0 and filled DB with demo data.

When i tap the account, i see the current balance with a lot of decimal digits:
Screenshot 2025-03-04 alle 22 50 51

Also the reconciliation transaction is created with the same problem on the DB:
Screenshot 2025-03-04 alle 22 51 08

I think that's just the limitation of the binary representation of floating point numbers. Can you check on that? Thank you! Other than that i think that your PR is ready for the next steps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Adjust balance of the account
3 participants