Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests via embUnit #381

Merged
merged 3 commits into from
Apr 11, 2014
Merged

Unittests via embUnit #381

merged 3 commits into from
Apr 11, 2014

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 25, 2013

Add Unittest framework embUnit and start writing tests.

Edit: Completely replaced minUnit with embUnit, as discussed in meeting ⇒ deleted obsolete comments

@miri64 miri64 added this to the Release 2014.04 milestone Mar 24, 2014
@miri64 miri64 changed the title Unittests via minunit.h Unittests via embUnit Mar 24, 2014
@miri64
Copy link
Member Author

miri64 commented Apr 1, 2014

@miri64
Copy link
Member Author

miri64 commented Apr 1, 2014

No longer WIP, please review. Actual tests for core moved to #961

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

readme.txt looks corrupted.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

For consistency I would prefer Makefile to be spelled with a capital M.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

Is there anything that can be actually reviewed in this PR?

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

.-(~/git/RIOT/tests/unittests/embunit)make

mkdir: cannot create directory ‘lib’: File exists
makefile:2: recipe for target 'all' failed
make: [all] Error 1 (ignored)
...
gcc -o samples AllTests.o counter.o counterTest.o person.o personTest.o -L../lib -lembUnit
/usr/bin/ld: cannot find -lembUnit
collect2: error: ld returned 1 exit status
makefile:12: recipe for target 'samples' failed
make[1]: *** [samples] Error 1
make[1]: Leaving directory '/home/oleg/git/RIOT/tests/unittests/embunit/samples'
makefile:2: recipe for target 'all' failed
make: [all] Error 2 (ignored)

Am I missing something?

@miri64
Copy link
Member Author

miri64 commented Apr 1, 2014

@OlegHahm miniscule Makefiles are from embunit. Please refer to #961 (or https://github.com/RIOT-OS/RIOT/wiki/Testing-RIOT) for building.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

I did and it says I should run

cd tests/unittests
make

@miri64
Copy link
Member Author

miri64 commented Apr 1, 2014

Above you were in tests/unittests/embunit according to your paste. Anyway, you need #961 to build something.

@OlegHahm
Copy link
Member

OlegHahm commented Apr 1, 2014

Ah, sorry, my bad.

@miri64 miri64 added tests and removed WIP labels Apr 1, 2014
@miri64
Copy link
Member Author

miri64 commented Apr 10, 2014

Rebased and squashed.

@OlegHahm
Copy link
Member

Looks good as far as I can tell. ACK

@miri64
Copy link
Member Author

miri64 commented Apr 11, 2014

So can I merge it?

OlegHahm added a commit that referenced this pull request Apr 11, 2014
@OlegHahm OlegHahm merged commit 3903b8a into RIOT-OS:master Apr 11, 2014
@miri64 miri64 deleted the unittests branch May 15, 2014 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework PR-award-nominee Deprecated. Will be removed soon. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants