sys/shell: removed route to show the RPL internal routing table
#2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BytesGalore
added
Area: network
| @@ -71,7 +71,7 @@ int _fib_route_handler(int argc, char **argv) | |||
| /* e.g. fibroute right now dont care about the adress/protocol family */ | |||
| if (argc == 1) { | |||
| fib_print_routes(); | |||
| return; | |||
| return 0; | |||
There was a problem hiding this comment.
The changes in this file are rather unrelated to the PR description, but they only fix a warning regarding return values.
So if there are no objections I would leave them inside and not open a new PR.
There was a problem hiding this comment.
moved it to a separate commit (#2812)
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 10, 2015
…le, this will be fixed with RIOT-OS#2782 merged
|
So, this should be merged after #2765, right? How about adding the corresponding dependency label? |
|
Nevertheless they should be merged more or less at the same time to ensure that we don't have a state without a route lookup command for a long time. |
|
@OlegHahm definitely, a short time distance between the both would be very beneficial :) |
|
ACK as soon as #2765 has been reviewed and ACked, too |
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 13, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 14, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 14, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
force-pushed
the
fib_adjust_shell_commands
branch
2 times, most recently
from
298e43e
to
5be4e36
Compare
BytesGalore
force-pushed
the
fib_adjust_shell_commands
branch
from
5be4e36
to
ee1c149
Compare
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 27, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Apr 28, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
May 4, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
force-pushed
the
fib_adjust_shell_commands
branch
from
ee1c149
to
ca19ec0
Compare
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Jul 15, 2015
…le, this will be fixed with RIOT-OS#2782 merged
BytesGalore
pushed a commit
to BytesGalore/RIOT
that referenced
this pull request
Jul 20, 2015
…le, this will be fixed with RIOT-OS#2782 merged
|
this PR is obsolete now, because it references the former nework stack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the FIB, RPL will eventually (#2765) use it to store the discovered next-hops.
This PR removes the route command that accesses the RPL internal routing table.