gnrc_netif: fix double free with netdev_new_api & gnrc_netif_pktq #20976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
Type: bug
miri64
reviewed
Nov 11, 2024
| @@ -1813,6 +1813,7 @@ static void _tx_done(gnrc_netif_t *netif, gnrc_pktsnip_t *pkt, | |||
| else { | |||
| /* remove previously held packet */ | |||
| gnrc_pktbuf_release(pkt); | |||
| return; | |||
| } | |||
| #endif /* IS_USED(MODULE_GNRC_NETIF_PKTQ) */ | |||
|
|
|||
There was a problem hiding this comment.
Maybe, just to prevent stuff like this in the future, also add an early/explicit return, in the if (gnrc_netif_netdev_new_api(netif)) { block?
miri64
approved these changes
Nov 11, 2024
|
Makes sense and saw the pain of @benpicco debugging this live unfolding. |
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Return early to prevent freeing the same packet again.
Testing procedure
Issues/PRs references