tests/pkg/emlearn: drop model.h from builddep #20908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that model.h is in the repo, it no longer is a build dependency. This allows compilation of the test without having emlearn installed, which is useful e.g. for build testing.
maribu
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Oct 14, 2024
benpicco
added
the
Impact: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Now that model.h is in the repo, it no longer is a build dependency. This allows compilation of the test without having emlearn installed, which is useful e.g. for build testing.
Testing procedure
Uninstall emlearn and run
make -C tests/pkg/emlearn. It should now work.Issues/PRs references
I should have done so in #20841 already