Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: Add shield_llcc68 module #20885

Merged
merged 2 commits into from
Oct 2, 2024
Merged

drivers: Add shield_llcc68 module #20885

merged 2 commits into from
Oct 2, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 1, 2024 •
edited
Loading

Contribution description

This implements the shield_llcc68 module that allows using the LLCC68 LoRa shield on Arduino UNO compatible boards (with Arduino IO mappings provided by the board) by just selecting the module.

Testing procedure

USEMODULE="shield_llcc68" make BOARD=wemos-zero PROGRAMMER=openocd OPENOCD_DEBUG_ADAPTER=jlink VERBOSE_ASSERT=1 -C examples/gnrc_networking term

2024-10-01 18:34:49,475 # ifconfig
2024-10-01 18:34:49,477 # Iface  6  Frequency: 868300000Hz  RSSI: -128  BW: 125kHz  SF: 7  CR: 4/5 
2024-10-01 18:34:49,477 #            State: STANDBY 
2024-10-01 18:34:49,479 #           MTU:65535  HL:64  RTR  
2024-10-01 18:34:49,479 #           RTR_ADV  
2024-10-01 18:34:49,480 #           Link type: wireless
2024-10-01 18:34:49,480 #           inet6 group: ff02::2
2024-10-01 18:34:49,480 #           inet6 group: ff02::1
2024-10-01 18:34:49,480 #           inet6 group: ff02::1a
2024-10-01 18:34:49,480 #           
2024-10-01 18:34:49,480 #           Statistics for Layer 2
2024-10-01 18:34:49,481 #             RX packets 0  bytes 0
2024-10-01 18:34:49,481 #             TX packets 0 (Multicast: 0)  bytes 0
2024-10-01 18:34:49,481 #             TX succeeded 0 errors 0
2024-10-01 18:34:49,481 #           Statistics for IPv6
2024-10-01 18:34:49,481 #             RX packets 0  bytes 0
2024-10-01 18:34:49,482 #             TX packets 0 (Multicast: 0)  bytes 0
2024-10-01 18:34:49,482 #             TX succeeded 0 errors 0
2024-10-01 18:34:49,482 #

Note

For this to work #20884 is also needed
UPDATE: This is now in master and this PR has been rebased. The proposed test will work in the PR branch out of the box.

Issues/PRs references

@github-actions github-actions bot added Area: doc Area: Documentation Area: build system Area: Build system Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support labels Oct 1, 2024
@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: doc Area: Documentation Area: build system Area: Build system Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support labels Oct 1, 2024
@riot-ci
Copy link

riot-ci commented Oct 1, 2024 •
edited
Loading

Murdock results

✔️ PASSED

8c2f6ae drivers: Add shield_llcc68 module

Success Failures Total Runtime
10197 0 10197 15m:36s

Artifacts

@maribu maribu force-pushed the drivers/shield_llcc68 branch from 27e8fea to e153acf Compare October 1, 2024 19:45
@github-actions github-actions bot added Area: doc Area: Documentation Area: build system Area: Build system Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support labels Oct 1, 2024
@maribu maribu force-pushed the drivers/shield_llcc68 branch from e153acf to 678ef7c Compare October 1, 2024 20:20
maribu added 2 commits October 2, 2024 09:48
@maribu
drivers/shield_w5100: pimp documentation
7bc7b73 
This adds a picture and a small fact table to the doc.
@maribu
drivers: Add shield_llcc68 module
8c2f6ae 
This implements the `shield_llcc68` module that allows using the LLCC68
LoRa shield on Arduino UNO compatible boards (with Arduino IO mappings
provided by the board) by just selecting the module.
@maribu maribu force-pushed the drivers/shield_llcc68 branch from 678ef7c to 8c2f6ae Compare October 2, 2024 07:48
benpicco
benpicco approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty handy!

@benpicco benpicco enabled auto-merge October 2, 2024 15:39
@benpicco benpicco added this pull request to the merge queue Oct 2, 2024
Merged via the queue into RIOT-OS:master with commit 153562f Oct 2, 2024
26 checks passed
@maribu
Copy link
Member Author

maribu commented Oct 2, 2024

Thx :)

@maribu maribu deleted the drivers/shield_llcc68 branch October 2, 2024 21:15
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: doc Area: Documentation Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2024.10
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @benpicco