-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tflite-micro: Update tflite-micro to latest version. requires update of pkg/flatbuffers as well. #20683
Conversation
I tried to build locally and got this error:
Any idea what it could be? |
Using |
Tested on native and nrf52840dk and it works! Good job! |
Can you prepend your 4 last commit messages with the right context ("pkg/tflite-micro: ", "pkg/flatbuffers: ") ? |
done!
I encountered the same issue when i had generated the schema using a different version of flatc than required. Just using the schema_generated already in the repo fixed it. |
Can you fix the check-commits check? https://github.com/RIOT-OS/RIOT/actions/runs/9207542826/job/25327831907?pr=20683#step:4:5.
|
Sorry to bother you again with 57abe1c
format is: short description on the first line, blank line, extended description. |
Because that's what tflite-micro depends on
Done. No worries. Maybe I just shouldn't have done this past midnight :) |
@@ -1,109 +1,29 @@ | |||
BOARD_INSUFFICIENT_MEMORY := \ | |||
airfy-beacon \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removing too many boards to be right. I doubt all those removed boards have enough memory. nrf51dk has only 8kB of RAM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated it through the RIOT/dist/tools/insufficient_memory/create_makefile.ci.sh
script, but i must admit i don't have that board to test it on. Running BOARD=nrf51dk make -C tests/pkg/tflite-micro/
it builds fine, but I can't actually run it. The closest i have access to is a microbit, and this compiles and works on that
Co-authored-by: Alexandre Abadie <alexandre.abadie@inria.fr>
Murdock timed out on compiling the test for |
This is now also popping up in the CI every now and then. There seems to be a race condition. |
The cause is that schema_generated.h is not using the proper flatc flags to generate the appropriate types. However, the tflite-micro repo already has the correct schema_generated.h so there is probably some funny stuff going on when make decide to regenerate it. I'll create a new PR with the fix. EDIT: PR #20703 |
Contribution description
This PR updates tflite-micro to the the latest version. Since the current version in Riot OS is quite old, this has mandated some other changes and updates:
The included flatbuffers pkg and dist/tools have been updated to v23.5.26 as thats the one tflite-micro uses.
The patch files to fix cast-align errors have been updated
The mnist example have been updated with new locations for headers and i've replaced the AllOpsResolver with mutable_ops_resolver, since the former has been deprecated. This requires the user to specify the exact operators needed, with an added bonus of a much smaller binary size.
Testing procedure
run the tests/pkg/tflite-micro test
Issues/PRs references