Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kconfig dependency modelling #20438

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Remove Kconfig dependency modelling #20438

merged 13 commits into from
Mar 28, 2024

Conversation

MrKevinWeiss
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss commented Feb 28, 2024 •
edited
Loading

Contribution description

As discussed on the forum and agreed upon in the VMA among other forms of communications we are removing the dependency modelling of Kconfig. As it was never part of the "production" RIOT and only available as an experimental feature (TEST_KCONFIG=1) I do not think we need to deprecate it.

This PR should remove everything dependency related but preserve all "kconfig for configurations" aspects.

It is a step in the direction of having "one source of truth" for configurations, many configurations that were only exposed when TEST_KCONFIG=1 are now exposed in a regular build (ie, depends on MODULE_* -> depends on USEMODULE_). These configurations are still not being used by default (for any test that does not have an app.config file present) as to not slow down the CI before the release but will be switched very soon.

There are quite some things needed in order to do this right:

  • Remove all obvious files that only are related to dep modelling (ideally just a script)
  • Remove all MODULE_ and PACKAGE_ configs and symbol references within remaining files
  • Alter all implemented CONFIG_ that have been implemented under the dep modelling to use the make dep modelling (ie. MODULE_ -> USEMODULE_)
  • Do manual fixes and alterations as needed
  • Cleanup any source issues for files that might be removed
  • Clean up the make system to remove all unneeded logic
  • Update the documentation to indicate the current state
  • Inject all the HAS_CPU* type features

Testing procedure

Green murdock and a lot of looking through

Issues/PRs references

Needs #20497

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: network Area: Networking Area: tests Area: tests and testing framework Area: pkg Area: External package ports Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: drivers Area: Device drivers Area: timers Area: timer subsystems Area: tools Area: Supplementary tools Area: arduino API Area: Arduino wrapper API Area: LoRa Area: LoRa radio support Area: boards Area: Board ports Area: SAUL Area: Sensor/Actuator Uber Layer Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms labels Feb 28, 2024
This was referenced Mar 26, 2024
Merged
Merged
@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@MrKevinWeiss
Copy link
Contributor Author

oh boy am I sad... OK back at it.

@MrKevinWeiss
Copy link
Contributor Author

Not only does the gcoap test fail, but also it seems like there are some issues with make info-boards-supported. Further investigation is needed... tomorrow.

@MrKevinWeiss
Copy link
Contributor Author

hmmm, way less of a problem than I though... just a conflict in values for SDCARD_GENERIC_MTD_OFFSET, I guess generally it should be 1?

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@MrKevinWeiss
Copy link
Contributor Author

Hmmm the failed test builds on my machine. Maybe something to do with rust on a CI machine?

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Mar 27, 2024
@benpicco benpicco removed this pull request from the merge queue due to a manual request Mar 27, 2024
@maribu maribu added this pull request to the merge queue Mar 27, 2024
Merged via the queue into RIOT-OS:master with commit 04620d4 Mar 28, 2024
25 checks passed
@maribu
Copy link
Member

maribu commented Mar 28, 2024

🎉 Thx!

@MrKevinWeiss MrKevinWeiss deleted the pr/kconfig/dep/removal branch March 28, 2024 13:38
@MrKevinWeiss
Copy link
Contributor Author

I didn't think I would make it. Nice that it is finally over. I will also prioritize any issues or bugs this may have causes.

@benpicco
Copy link
Contributor

Thank you for bringing the Kconfig transition to a close!

@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@mguetschow mguetschow mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@jeandudey jeandudey Awaiting requested review from jeandudey jeandudey is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@keestux keestux Awaiting requested review from keestux keestux is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx is a code owner

@kYc0o kYc0o Awaiting requested review from kYc0o kYc0o is a code owner

@nandojve nandojve Awaiting requested review from nandojve nandojve is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: arduino API Area: Arduino wrapper API Area: BLE Area: Bluetooth Low Energy support Area: boards Area: Board ports Area: build system Area: Build system Area: CoAP Area: Constrained Application Protocol implementations Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System Area: tests Area: tests and testing framework Area: timers Area: timer subsystems Area: tools Area: Supplementary tools Area: USB Area: Universal Serial Bus CI: high priority If set, builds of this PR will be queued before others CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: native Platform: This PR/issue effects the native platform Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@MrKevinWeiss @riot-ci @maribu @benpicco