pkg/openthread: Fix Kconfig and broken example #19700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: examples
It seems like the openthread package has some 'non-reproducible' builds so we just disable it by renaming the app.config.test so murdock will not pick it up. Probably something to do with a timestamp.
MrKevinWeiss
force-pushed
the
pr/fixopenthread
branch
from
a2e68be to
f1f4f20
Compare
maribu
approved these changes
Jun 2, 2023
MrKevinWeiss
added
the
CI: ready for build
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
I feel that is probably unrelated... |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
There were some improvements that could be make to the kconfig modeling of the
pkg/openthreadafter looking a bit closer.The bigger problem is the hash check on nightlies require reproducible builds, however, even with make, the builds are not reproducible. So, for now, I just rename the
app.config.testtoskip.app.config.testto prevent murdock from trying to do a hash check but still letting it be useable.Testing procedure
Green murdock, all modules match
examples/openthreadskip.app.config.testtoapp.config.testIssues/PRs references
Fixes an aspect of broken master