Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6_nib: include RIO with all subnets in downstream RA #19644

Merged
merged 2 commits into from
May 23, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented May 22, 2023

Contribution description

When RIOT is an upstream router to a subnet, but not the default route, we need to convey the information that this subnet is available through it to the downstream hosts.

Testing procedure

A riot board is connected to a Raspberry Pi over USB. The Raspberry Pi also has a WiFi uplink that constitutes it's default route.

The RIOT node is part of the fd00::/32 network, but by use of gnrc_ipv6_auto_subnets it's actually in the fd00:0:c000::/64 subnet.

To reach the fd00::1 host at the root of the upstream subnet, we have to inform the Raspberry Pi that the entire fd00::/32network is reachable through the RIOT node, not justfd00:0:c000::/64` - we can use the Route Information Option for that.

We don't want to include redundant RIOs in the RA, e.g. the networks fd00:0:8000::/33 and fd00:0:c000::/64 are both included in fd00::/32 (which is also reachable through our node) so we only have to include that one.

2023-05-23 14:54:46,023 - INFO # fd00::/32 via fe80::5884:f712:f280:5db9 dev #7
2023-05-23 14:54:46,025 - INFO # fd00:0:8000::/33 dev #7
2023-05-23 14:54:46,028 - INFO # fd00:0:c000::/64 dev #8
2023-05-23 14:54:46,032 - INFO # default via fe80::5884:f712:f280:5db9 dev #7

and on the Linux side

fd00:0:c000::/64 dev usb0 proto kernel metric 256 expires 80072sec pref medium
fd00:0:c000::/64 dev usb0 proto ra metric 303 pref medium
fd00::/32 via fe80::6481:20ff:fef9:b694 dev usb0 proto ra metric 1024 expires 4288820sec pref medium
fe80::/64 dev usb0 proto kernel metric 256 pref medium
default via fe80::6481:20ff:fef9:b694 dev usb0 proto ra metric 303 pref medium
default via fe80::6481:20ff:fef9:b694 dev usb0 proto ra metric 1024 expires 1606sec pref medium

Issues/PRs references

@benpicco benpicco requested a review from fabian18 May 22, 2023 11:04
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 22, 2023
@fabian18
Copy link
Contributor

Why should it be optional in final RAs but is always included in normal RAs?

@benpicco benpicco force-pushed the gnrc_nib-router_rio branch from 62e1fe1 to 5e182b5 Compare May 23, 2023 13:09
@benpicco benpicco marked this pull request as ready for review May 23, 2023 13:10
@benpicco benpicco force-pushed the gnrc_nib-router_rio branch from 5e182b5 to 4a5d68a Compare May 23, 2023 13:10
@benpicco
Copy link
Contributor Author

It's now also optional in normal RAs (and even more so as it's only needed when we are a) not the default router but have b) a route to a specific subnet we want to propagate).

@benpicco benpicco force-pushed the gnrc_nib-router_rio branch from 4a5d68a to fa5fd21 Compare May 23, 2023 14:23
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2023
@fabian18
Copy link
Contributor

I'd say resolve the conflict and let's go.

@benpicco benpicco force-pushed the gnrc_nib-router_rio branch from fa5fd21 to 41f9c25 Compare May 23, 2023 14:46
@riot-ci
Copy link

riot-ci commented May 23, 2023

Murdock results

✔️ PASSED

771e9e9 gnrc/ipv6_auto_subnets: remove superfluous newline

Success Failures Total Runtime
6946 0 6946 10m:34s

Artifacts

@benpicco
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a272abb into RIOT-OS:master May 23, 2023
@benpicco benpicco deleted the gnrc_nib-router_rio branch May 23, 2023 23:29
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants