tests/shell: add test for preemption #19005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
miri64,
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
benpicco
added
the
State: waiting for other PR
benpicco
force-pushed
the
tests/shell-preempt
branch
from
59fe7ab to
51b6bab
Compare
benpicco
added
CI: ready for build
benpicco
force-pushed
the
tests/shell-preempt
branch
from
51b6bab to
29f873a
Compare
benpicco
added
CI: ready for build
|
Looks okay from a first glance. You should add a comment on what that function is testing and how it is doing it. Otherwise it is not clear what is going on / the intentions. |
|
I also took the opportunity to simplify the test a bit, so it still fits on tiny MCUs. |
benpicco
force-pushed
the
tests/shell-preempt
branch
from
fbc94c1 to
819ebbd
Compare
|
LGTM. Not super happy with the very short comment but 'eh, good enough. |
benpicco
force-pushed
the
tests/shell-preempt
branch
from
819ebbd to
69805d2
Compare
Teufelchen1
approved these changes
Mar 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@benpicco murdock is not happy, can you take a look? |
This tests if a blocking stdio read will allow other threads to be scheduled.
benpicco
force-pushed
the
tests/shell-preempt
branch
from
69805d2 to
ac383b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This tests if a blocking stdio read will allow other threads to be scheduled.
Testing procedure
periodic test 5should printtest5 times from a separate threadIssues/PRs references
requires #19002 to work on
native