drivers/at86rf2xx: define caps in macros #18967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Type: cleanup
benpicco
approved these changes
Nov 24, 2022
benpicco
added
the
CI: ready for build
|
I accidentally swapped some of the conditions. I already fixed that in the last push and renamed |
|
I could nitpick that |
jia200x
force-pushed
the
pr/at86rf2xx_define_caps
branch
from
99ac9fc
to
5a865c3
Compare
Addressed and directly squashed |
Murdock results✔️ PASSED 5a865c3 drivers/at86rf2xx: add HAVE_RETRIES_REG macro
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
It has been very hard to port AT86RF based radios to the Radio HAL because the presentation layer is mixed with the interface layer (netdev). Even more, variant specific stuff are scattered everywhere, which makes it hard to write a compatible Radio HAL interface. Therefore, I think the only way to move forward is to clean-up the driver a bit.
This PR tries to define variant specific caps (e.g
HAVE_ED_REGISTER,HAVE_SUBGHZ,AT86RF2XX_PERIPH) based on the variant.In a follow up, I plan to move the PERIPH parts to its own file and separate the SPI implementation with the PERIPH version. The idea is to have provide a common abstraction for the hardware interface layer, so it becomes relatively straight forward to replace
at86rf2xx_netdev.cwithat86rf2xx_rf_ops.c. With some tweaks, it should be also possible to run multiple variants on the same firmware.Testing procedure
Check that AT86RF2XX variants still work as expected.
Issues/PRs references
#16535