drivers/ethos: Fix off-by-one bug [backport 2022.10] #18831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Area: drivers
Murdock results❌ FAILED 8aa4e2a drivers/ethos: Fix off-by-one in ETHOS driver Build failures (1)
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
miri64
approved these changes
Nov 1, 2022
(cherry picked from commit b1dff29)
maribu
force-pushed
the
backport/2022.10/master
branch
from
c1c9a13 to
8aa4e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18823
The ethernet over serial driver
_recvfunction checks the buffer size after writing the data.To fix this I moved the bounds check before the function writing to the buffer.