Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/efm32: add series 2 cpu EFR32ZG23 #18760

Closed
wants to merge 11 commits into from
Closed

cpu/efm32: add series 2 cpu EFR32ZG23 #18760

wants to merge 11 commits into from

Conversation

jue89
Copy link
Contributor

@jue89 jue89 commented Oct 17, 2022 •
edited
Loading

Contribution description

This PR brings the Gecko series 2 to RIOT:

Current progress of this PR:

  • Clock setup
  • periph_gpio
  • periph_uart
  • periph_timer
  • periph_spi
  • periph_i2c
  • periph_hwrng
  • periph_wdt
  • Documentation for the board xg23a-pk6068a

Testing procedure

TBD

Issues/PRs references

Based on:

@jue89 jue89 added Platform: ARM Platform: This PR/issue effects ARM-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Oct 17, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Oct 17, 2022
@benpicco benpicco requested a review from gschorcht October 17, 2022 21:27
@riot-ci
Copy link

riot-ci commented Oct 17, 2022 •
edited
Loading

Murdock results

✔️ PASSED

40bd412 boards/xg23b-pk6068a: initial commit

Success Failures Total Runtime
1989 0 1991 06m:35s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

gschorcht
gschorcht reviewed Oct 17, 2022
View reviewed changes
boards/xg23b-pk6068a/Makefile.features
CPU_MODEL = efr32zg23a020f512gm48

# Put defined MCU peripherals here (in alphabetical order)
FEATURES_PROVIDED += periph_uart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it necessary for this board to include the makefiles from boqards/common/silabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint! Currently, the makefiles pull in too many provided features that aren't supported, yet. Thus, I skipped it for now. Once everything is in place, I'll add these.

@jue89
Copy link
Contributor Author

jue89 commented Oct 18, 2022

Would someone mind if I squash after the currently pending Murdock run? History is already getting messy :D

@gschorcht gschorcht mentioned this pull request Oct 18, 2022
Merged
@gschorcht
Copy link
Contributor

@jue89 Some of the commits are needed for this PR, but could be split off to be merged as a separate PR before the work on this PR is complete. These are commits 3885e4b 6ec0135 4b4ec19 1b6a761. Do you mind to open another PR for such commits?

@jue89
Copy link
Contributor Author

jue89 commented Oct 18, 2022

Sure, I can split them off.

@jue89 jue89 mentioned this pull request Oct 18, 2022
Merged
@jue89 jue89 added the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 18, 2022
@jue89 jue89 force-pushed the feature/efm32-series2 branch 6 times, most recently from ad5e3e4 to 8f437d7 Compare October 19, 2022 09:00
@benpicco benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Oct 19, 2022
@jue89 jue89 force-pushed the feature/efm32-series2 branch from 8f437d7 to 40bd412 Compare October 19, 2022 11:05
@jue89
Copy link
Contributor Author

jue89 commented Oct 19, 2022 •
edited
Loading

Ohhh, I just noticed, I used the global RIOT repository for this feature branch 😲

After the finished Murdock run, I'll move this branch to my fork of RIOT and will open a new PR. I'm really sorry for the inconvenience and will do a refresher training on using GIT correctly ;-)

@gschorcht
Copy link
Contributor

@jue89 Please let me know when the PR is ready for review. The list of supported peripherals is complete but the label WIP is still set.

@jue89
Copy link
Contributor Author

jue89 commented Oct 19, 2022

@jue89 Please let me know when the PR is ready for review. The list of supported peripherals is complete but the label WIP is still set.

Some documentation for the board is missing. But aside from that, this is ready to be reviewed.

@jue89 jue89 mentioned this pull request Oct 20, 2022
Merged
11 tasks
@jue89
Copy link
Contributor Author

jue89 commented Oct 20, 2022

@gschorcht can I close this PR and remove the accidentally created feature branch in the main RIOT repo?

Further reviews should be done in #18780.

gschorcht
gschorcht reviewed Oct 20, 2022
View reviewed changes
boards/xg23b-pk6068a/Makefile.features
CPU_FAM = efr32zg23
CPU_MODEL = efr32zg23a020f512gm48

# Put defined MCU peripherals here (in alphabetical order)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the features that other SiliconLabs MCUs have?
periph_adc
periph_rtc
periph_rtt
periph_uart_modecfg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not implemented, yet. I'll add them on a follow-up PR. periph_pwm and periph_dac are missing, too ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you add them to the PR or as separate PRs? You should add entries for them in the task list in former case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely separate PR. This PR is already kinda huge.

@gschorcht
Copy link
Contributor

@gschorcht can I close this PR and remove the accidentally created feature branch in the main RIOT repo?

Sure.

@jue89 jue89 closed this Oct 20, 2022
@jue89 jue89 deleted the feature/efm32-series2 branch October 20, 2022 14:29
@jue89 jue89 mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht left review comments

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri will be requested when the pull request is marked ready for review leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x will be requested when the pull request is marked ready for review jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss will be requested when the pull request is marked ready for review MrKevinWeiss is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx will be requested when the pull request is marked ready for review basilfx is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jue89 @riot-ci @gschorcht @benpicco