nanocoap_sock: deprecate nanocoap_get() #18752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an old holdover, all in-tree users have been converted to use nanocoap_sock_get() or similar functions.
benpicco
added
the
Process: deprecation
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 1ec834f nanocoap_sock: deprecate nanocoap_get()
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
maribu
approved these changes
Jan 6, 2023
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is an old holdover, all in-tree users have been converted to use
nanocoap_sock_get()or similar functions.Should we also drop
nanocoap_request()in favor ofnanocoap_sock_request()?Testing procedure
Issues/PRs references