Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/stdio_uart: add stdio_uart_onlcr (pseudo-) module #18731

Merged
merged 1 commit into from
Oct 15, 2022
Merged

sys/stdio_uart: add stdio_uart_onlcr (pseudo-) module #18731

merged 1 commit into from
Oct 15, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Oct 12, 2022

Contribution description

Add USE_MODULE += "stdio_uart_onlcr" to enable it. This is named after the "onlcr" stty flag, which does the same thing.

Testing procedure

USEMODULE=stdio_uart_onlcr make BOARD=<board-with-stdio_uart> -C examples/default

The shell should now work with a terminal that expects DOS line endings.

Issues/PRs references

Alternative to: #18703 and #15619

This is basically picking up #15619 and polishing it a bit.

@maribu maribu requested a review from benpicco October 12, 2022 20:51
@github-actions github-actions bot added Area: build system Area: Build system Area: sys Area: System labels Oct 12, 2022
This was referenced Oct 12, 2022
Closed
Open
@maribu maribu force-pushed the sys/stdio_uart/onlcr branch from cf97115 to a9e9ca3 Compare October 13, 2022 07:21
@maribu
Copy link
Member Author

maribu commented Oct 13, 2022

Tested again, still works:

$ unset BT_PORT_CRLF
$ make BOARD=nrf52840dk flash -C examples/default
[...]
$ bt 
                                           main(): This is RIOT! (Version: 2022.10-devel-1112-ga9e9c-sys/stdio_uart/onlcr)
                                                                                                                          Welcome to RIOT!
                                                                                                                                          > NETOPT_TX_END_IRQ not implemented by driver

$ unset BT_PORT_CRLF
$ make BOARD=nrf52840dk flash -C examples/default
$ USEMODULE=stdio_uart_onlcr make BOARD=nrf52840dk flash -C examples/default
$ bt
main(): This is RIOT! (Version: 2022.10-devel-1112-ga9e9c-sys/stdio_uart/onlcr)
Welcome to RIOT!
> help
Command              Description
---------------------------------------
ifconfig             Configure network interfaces
pm                   interact with layered PM subsystem
ps                   Prints information about running threads.
reboot               Reboot the node
saul                 interact with sensors and actuators using SAUL
txtsnd               Sends a custom string as is over the link layer
version              Prints current RIOT_VERSION

benpicco
benpicco reviewed Oct 13, 2022
View reviewed changes
sys/stdio_uart/stdio_uart.c Outdated Show resolved Hide resolved
sys/stdio_uart/stdio_uart.c Show resolved Hide resolved
@benpicco
Copy link
Contributor

Please squash directly

@jimparis @maribu
sys/stdio_uart: add stdio_uart_onlcr (pseudo-) module
d797c99 
Add USE_MODULE += "stdio_uart_onlcr" to enable it.
This is named after the "onlcr" stty flag, which does the same thing.

Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
@maribu maribu force-pushed the sys/stdio_uart/onlcr branch from a9e9ca3 to d797c99 Compare October 13, 2022 10:09
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 13, 2022
@riot-ci
Copy link

riot-ci commented Oct 13, 2022 •
edited
Loading

Murdock results

✔️ PASSED

d797c99 sys/stdio_uart: add stdio_uart_onlcr (pseudo-) module

Success Failures Total Runtime
1983 0 1983 06m:31s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022
@benpicco benpicco merged commit 5c9715a into RIOT-OS:master Oct 15, 2022
@maribu maribu mentioned this pull request Jan 5, 2023
Closed
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
@maribu maribu deleted the sys/stdio_uart/onlcr branch April 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
6 participants
@maribu @benpicco @riot-ci @kaspar030 @dylad @jimparis