sys/checksum: add CRC-32 checksum #18686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
benpicco
force-pushed
the
checksum/crc32
branch
from
c12a048 to
ab3e5bd
Compare
benpicco
force-pushed
the
checksum/crc32
branch
from
ab3e5bd to
c112333
Compare
github-actions
bot
added
Area: doc
maribu
reviewed
Oct 4, 2022
maribu
approved these changes
Oct 4, 2022
benpicco
force-pushed
the
checksum/crc32
branch
2 times, most recently
from
cf3f7cd to
f5bfba6
Compare
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED df159b4 codespell: add false positive for El Didi
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
benpicco
force-pushed
the
checksum/crc32
branch
from
d6379d2 to
df159b4
Compare
kaspar030
reviewed
Oct 4, 2022
| * Copyright (C) 2020 Ayman El Didi | ||
| * | ||
| * To the extent possible under law, the author(s) have dedicated all | ||
| * domain worldwide. This software is distributed without any warranty. |
There was a problem hiding this comment.
is that sentence missing something? e.g., "...software to the public..."?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The CRC-32 checksum algorithm was previously absent in RIOT, so add it.
This is with the polynomial used by e.g. Ethernet, SATA, PNG, etc.
Testing procedure
A new unit test was added to
tests-checksum.Issues/PRs references