Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Update versions #18181

Merged
merged 1 commit into from
Jun 9, 2022
Merged

rust: Update versions #18181

merged 1 commit into from
Jun 9, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Jun 8, 2022 •
edited
Loading

Contribution description

This updates riot-sys and riot-wrappers to their latest git versions (along with some other crates mainly from the build system), providing:

  • Add and use the coap_request_ctx_t marker for nanocoap: define and use coap_request_ctx_t for request handlers #17957
    • If that PR goes through as it is now, its API change is hidden from Rust users already with the latest changes here.
  • Avoid theoretical undefined behavior around packed structs. (This was always there, but rustc is becoming stricter; this also unblocks the next CI upgrade where the nightly version would be bumped).
  • Remove legacy code (for supporting RIOT before 2022.04), and cleanups.

(and a lot of README, CI and URI updates that are not really visible inside RIOT)

Testing procedure

  • Green CI (with tests enabled)

@chrysn chrysn added Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: Rust Area: Rust wrapper labels Jun 8, 2022
@chrysn chrysn added CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed Area: tests Area: tests and testing framework labels Jun 8, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: tests Area: tests and testing framework labels Jun 8, 2022
@benpicco
Copy link
Contributor

benpicco commented Jun 9, 2022

#17957 is now compiling, thank you for providing the updated bindings 😃

@chrysn chrysn enabled auto-merge June 9, 2022 09:30
@chrysn chrysn merged commit f4691db into RIOT-OS:master Jun 9, 2022
@chrysn chrysn deleted the rust-updates-20220608 branch June 9, 2022 11:52
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
2 participants
@chrysn @benpicco