Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/vfs: add vfs_unmount_by_path() #18109

Merged
merged 1 commit into from
May 17, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

If we mount a file system by path we also might want to unmount it, e.g. for clean shutdown or reboot.

Just adds a function that does the same as vfs_mount_by_path() but with unmount instead of mount.

Testing procedure

Issues/PRs references

Complements #17661

@benpicco benpicco requested a review from chrysn May 16, 2022 09:14
@github-actions github-actions bot added the Area: sys Area: System label May 16, 2022
@fjmolinas
Copy link
Contributor

Funny I had the same added in another project 33c02b4, I used it because when using native with gcoap-fileserver I could copy new files in, and re-mounting re-freshed what files native used. I can ACK this right away, unless you would think a rmount function would be useful as well :)

@benpicco
Copy link
Contributor Author

I also like the vfs mkdir function you added there 😃

The vfs mount vfs unmount commands would sure be useful, want to make a PR for that?

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 17, 2022
@fjmolinas
Copy link
Contributor

I also like the vfs mkdir function you added there smiley

The vfs mount vfs unmount commands would sure be useful, want to make a PR for that?

Lets get this in then!

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@benpicco benpicco enabled auto-merge May 17, 2022 13:00
@benpicco benpicco merged commit cabb0b7 into RIOT-OS:master May 17, 2022
@benpicco benpicco deleted the vfs_unmount_by_path branch May 17, 2022 21:44
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants