gcoap: small dependencies fixes #17944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GCOAP requires random functions - openwsn_sock_udp is elected if openwsn stack is used and sock_udp as well, so remove redundant dependency
fjmolinas
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
aabadie
reviewed
Apr 14, 2022
Comment on lines
-651
to
-653
| ifneq (,$(filter openwsn%,$(USEMODULE))) | ||
| USEMODULE += openwsn_sock_udp | ||
| endif |
There was a problem hiding this comment.
This removal seems unrelated.
There was a problem hiding this comment.
Its in the commit message 34eb656
benpicco
added
the
CI: ready for build
miri64
changed the title
|
All green @benpicco |
benpicco
approved these changes
Apr 14, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
gcoapusesrandombut does not pull it indirectly, this fixes it. It's currently not shown because all possible network stacks pull inrandomfor it.