tests: rework ieee802154 drivers #17838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
requested review from
leandrolanzieri,
jia200x,
cgundogan,
smlng,
aabadie,
MichelRottleuthner,
fjmolinas,
miri64,
haukepetersen,
PeterKietzmann,
bergzand,
daniel-k,
benpicco and
kaspar030
as code owners
github-actions
bot
added
Area: boards
MrKevinWeiss
changed the title
MrKevinWeiss
added
the
CI: ready for build
MrKevinWeiss
force-pushed
the
pr/tests/154_drivers_rework
branch
from
23719fc to
461c045
Compare
github-actions
bot
removed
the
Area: CI
MrKevinWeiss
force-pushed
the
pr/tests/154_drivers_rework
branch
from
461c045 to
da892ca
Compare
github-actions
bot
removed
Area: boards
maribu
reviewed
Jul 5, 2022
MrKevinWeiss
force-pushed
the
pr/tests/154_drivers_rework
branch
from
d21f321 to
2eac520
Compare
|
Done, thanks for the review @maribu |
maribu
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
ACK. Code looks good. I tested with tests/driver_at86rf2xx using the samr21-xpro and with tests/driver_at86rf215 using our custom miot-nucleo-f767zi testbed board. There is one issue with the AT86RF215 test application, as that needs to allocate twice the number of netdevs, as the sub-GHz and the 2.4 GHz transceiver in that chip are represented as two netdevs in RIOT. I already tested it successfully with the proposed changes.
tests/driver_at86rf215/init_dev.h
Outdated
| #endif | ||
|
|
||
| #define AT86RF215_NUM ARRAY_SIZE(at86rf215_params) | ||
| #define NETDEV_IEEE802154_MINIMAL_NUMOF AT86RF215_NUM |
There was a problem hiding this comment.
Suggested change
| #define NETDEV_IEEE802154_MINIMAL_NUMOF AT86RF215_NUM | |
| /* AT86RF215 contains one sub-GHz and one 2.4 GHz driver */ | |
| #define NETDEV_IEEE802154_MINIMAL_NUMOF (2 * AT86RF215_NUM) |
tests/driver_at86rf215/main.c
Outdated
| #include "od.h" | ||
|
|
||
| static char batmon_stack[THREAD_STACKSIZE_MAIN]; | ||
| static at86rf215_t *dev; | ||
| static at86rf215_t at86rf215[AT86RF215_NUM]; |
There was a problem hiding this comment.
Suggested change
| static at86rf215_t at86rf215[AT86RF215_NUM]; | |
| static at86rf215_t at86rf215[NETDEV_IEEE802154_MINIMAL_NUMOF]; |
|
😢 |
This index is used to register the network device.
MrKevinWeiss
force-pushed
the
pr/tests/154_drivers_rework
branch
from
2eac520 to
37bdc32
Compare
|
ping @maribu applied the fixes and rebased. |
maribu
approved these changes
Jul 11, 2022
|
Many thanks @leandrolanzieri @maribu and @jia200x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Split from #17789, but with a difference: instead of using symlinks the common functionality to interact with ieee802154 netdev drivers is implemented in its own test_utils module.
Testing procedure
Issues/PRs references
Split from #17789
Similar to #17813