-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/cst816s: add touch_dev interface + add Kconfig + migrate to ztimer #17459
Conversation
01162e1
to
a1b0f52
Compare
a1b0f52
to
5470193
Compare
48cb3e2
to
0f780d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, untested ack otherwise
0f780d6
to
1dd5561
Compare
Missing the actual ACk @bergzand :) |
I tested it on my pinetime last week, and it doesn't work (failed assertion the nrf i2c driver because the i2c dev index is not < |
Can you print the |
Unfortunately, my pinetime programming wires didn't survive my (little) programming/debugging session. |
1dd5561
to
294cfd9
Compare
1652bf6
to
881b3c2
Compare
@fjmolinas kindly brought me a couple (2!!!) of programming wires but I didn't succeed in having the touch panel to work. Note that it was not working on master and some old releases. |
Good news! I was able to test this one and it works like a charm! tests/driver_cst816s
tests/touch_dev
This is good to go I think :) |
881b3c2
to
dbc59aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Contribution description
This PR extends the cst816s touch panel driver with the following:
Testing procedure
tests/touch_dev
should work on the pinetime (untested)Issues/PRs references
None