Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/lpc23xx: model kconfig #17279

Merged
merged 8 commits into from
Dec 1, 2021
Merged

cpu/lpc23xx: model kconfig #17279

merged 8 commits into from
Dec 1, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models modules for the lpc23xx CPU and its related boards:

  • avsextrem
  • mcb2388
  • msba2

It also includes some changes on drivers to follow the current modelling approach using feature symbols.

Testing procedure

  • Green CI
  • The list of used symbols should match when using Kconfig and Makefile.

Issues/PRs references

Part of #16875

@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 26, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 26, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 26, 2021
Closed
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 26, 2021
benpicco
benpicco approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@leandrolanzieri
Copy link
Contributor Author

@benpicco could you take a look at the last 2 commits? Now these boards are actually bringing the mtd_mci which showed an issue with tests/pkg_fatfs_vfs, I think it should work now but I don't have the board to test.

@fjmolinas
Copy link
Contributor

ping @benpicco :)

@benpicco
Copy link
Contributor

looks good to me - but needs a rebase

@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/lpc23xx/model_kconfig branch from e875033 to f3ccf28 Compare December 1, 2021 09:12
@leandrolanzieri
Copy link
Contributor Author

Rebased

@aabadie
Copy link
Contributor

aabadie commented Dec 1, 2021

5666d1b has to be dropped

@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/lpc23xx/model_kconfig branch from f3ccf28 to eb4bbb8 Compare December 1, 2021 10:12
@leandrolanzieri
Copy link
Contributor Author

5666d1b has to be dropped

Dropped

@aabadie aabadie merged commit a2cfbe9 into RIOT-OS:master Dec 1, 2021
@leandrolanzieri leandrolanzieri deleted the pr/cpu/lpc23xx/model_kconfig branch December 1, 2021 12:32
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
4 participants
@leandrolanzieri @fjmolinas @benpicco @aabadie