Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/saml21-based: model kconfig #17270

Merged
merged 4 commits into from
Nov 29, 2021
Merged

boards/saml21-based: model kconfig #17270

merged 4 commits into from
Nov 29, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models Kconfig for saml21-based boards:

  • bastwan
  • saml21-xpro
  • samr30-xpro
  • samr34-xpro
  • yarm

It also changes the way sx127x drivers are modelled and models USB ACM CDC stdio.

Testing procedure

  • Check the Kconfig changes and modelling
  • Green CI

Issues/PRs references

Part of #16875

@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: sys Area: System Area: USB Area: Universal Serial Bus labels Nov 25, 2021
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: USB Area: Universal Serial Bus and removed Area: drivers Area: Device drivers Area: CI Area: Continuous Integration of RIOT components Area: LoRa Area: LoRa radio support Area: boards Area: Board ports Area: USB Area: Universal Serial Bus Area: sys Area: System Area: Kconfig Area: Kconfig integration labels Nov 25, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 25, 2021
Closed
@dylad
Copy link
Member

dylad commented Nov 25, 2021

Overall looks good to me but Murdock isn't happy.

@github-actions github-actions bot added Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework labels Nov 26, 2021
@leandrolanzieri
Copy link
Contributor Author

Overall looks good to me but Murdock isn't happy.

The sx127x test app configuration did not reflect the change in the Kconfig symbols, 667ca81 should fix this

@MrKevinWeiss
Copy link
Contributor

Murdock is happy, please remove the extra commit!

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/saml21/model_kconfig branch from 667ca81 to d19e9c4 Compare November 26, 2021 10:04
@leandrolanzieri
Copy link
Contributor Author

Done!

@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 26, 2021
MrKevinWeiss
MrKevinWeiss approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing worked it looks good, ACK!

@MrKevinWeiss MrKevinWeiss merged commit 7f649aa into RIOT-OS:master Nov 29, 2021
@leandrolanzieri
Copy link
Contributor Author

Thanks for the review!

@leandrolanzieri leandrolanzieri deleted the pr/boards/saml21/model_kconfig branch November 29, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: sys Area: System Area: tests Area: tests and testing framework Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @dylad @MrKevinWeiss