Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/common/saml1x: model kconfig #17263

Merged
merged 1 commit into from
Nov 25, 2021
Merged

boards/common/saml1x: model kconfig #17263

merged 1 commit into from
Nov 25, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

SAML1X CPU requires no special handling for Kconfig, this just adds the missing boards common module. The boards using this CPU are:

  • saml10-xpro
  • saml11-xpro

4afc1e9 limits the CI to test only these boards.

Testing procedure

  • Green CI

Issues/PRs references

Part of #16875

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Nov 24, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 24, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: Kconfig Area: Kconfig integration labels Nov 24, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 24, 2021
Closed
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 24, 2021
dylad
dylad approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The build issues on Murdock are unrelated right ?

@leandrolanzieri
Copy link
Contributor Author

The build issues on Murdock are unrelated right ?

Hmm no, I may be missing some defaults. I'll check.

@leandrolanzieri
Copy link
Contributor Author

The build issues on Murdock are unrelated right ?

Hmm no, I may be missing some defaults. I'll check.

Yeah, I forgot to indicate that saul_gpio is there. This should work now.

@dylad
Copy link
Member

dylad commented Nov 25, 2021

Murdock is happy !
please squash

@leandrolanzieri leandrolanzieri force-pushed the pr/boards/saml1x/model_kconfig branch from cf5be0a to 776875a Compare November 25, 2021 10:35
@leandrolanzieri
Copy link
Contributor Author

Murdock is happy ! please squash

Done, thanks for the review!

@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Nov 25, 2021
@dylad
Copy link
Member

dylad commented Nov 25, 2021

here we go!

@dylad dylad merged commit 8138a3e into RIOT-OS:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @dylad