cpu/avr8: model kconfig #16929

leandrolanzieri · 2021-10-01T11:33:49Z

Contribution description

This models the Kconfig modules for all avr8-based CPUs and boards. I only included a subset of the enabled boards for CI testing, one per modelled CPU model. The complete list is:

arduino-duemilanove
arduino-leonardo
arduino-mega2560
arduino-nano
arduino-uno
atmega1284p
atmega256rfr2-xpro
atmega328p-xplained-mini
atmega328p
atxmega-a1-xplained
atxmega-a1u-xpro
atxmega-a3bu-xplained
avr-rss2
derfmega128
derfmega256
mega-xplained
microduino-corerf
zigduino

A note on driver modelling

This also includes some changes on the modelling of certain drivers. The idea is that platforms can select HAVE_ hidden symbols to indicate on-board hardware, and then drivers can use this information to change their default value (e.g. a sensor driver would enable itself if the platform has it and MODULE_SAUL_DEFAULT is selected). To deal with this default, without falling into this issue, the prompts are hidden. The approach has been discussed offline with @fjmolinas and @MrKevinWeiss, but of course open for discussion.

For examples of this see 00b61cc and 0f960c2.

Testing procedure

Green CI
Check the modelling and compare make info-modules list with and without TEST_KCONFIG=1, they should match.

Issues/PRs references

#16875

maribu

lgtm :-)

cpu/atmega_common/periph/Kconfig

drivers/at30tse75x/Kconfig

fjmolinas · 2021-10-05T14:50:53Z

ping @maribu

maribu

ACK :-)

benpicco · 2021-10-15T10:08:25Z

This needs a rebase

leandrolanzieri · 2021-11-01T08:59:13Z

Rebased

MrKevinWeiss · 2021-11-01T09:45:23Z

it seems the rebase introduced some differences, for one the make version of tests/driver_bq2429x now has periph_init_nvm periph_nvm modules and the kconfig is missing them (even though there is no difference in the binary)

MrKevinWeiss · 2021-11-01T09:47:15Z

side note, maybe we should get murdock to run something like make clean -C $TEST && make info-modules -C $TEST > /tmp/no-kconfig && make clean -C $TEST && TEST_KCONFIG=1 make info-modules -C $TEST > /tmp/kconfig && diff /tmp/no-kconfig /tmp/kconfig with maybe a pkg variant too when something is failed to make the error a bit clearer?

leandrolanzieri · 2021-11-01T10:46:49Z

it seems the rebase introduced some differences, for one the make version of tests/driver_bq2429x now has periph_init_nvm periph_nvm modules and the kconfig is missing them (even though there is no difference in the binary)

I added f41b8a2. AFAIU periph_nvm is needed when periph_cpuid.

maribu · 2021-11-01T12:49:09Z

Some background for the waspmote-pro issue: xtimer is not compatible with boards that do not have timers running at frequencies that can be converted to 1 MHz via shifting only, except for 32.768 kHz which also works.

The waspmote-pro pulls in the xtimer_on_ztimer module if xtimer is used, as ztimer can convert via ztimer_convert_frac arbitrary frequencies fast with good enough precision, or with ztimer_convert_muldiv64 arbitrary frequencies with high precision but slower.

If code includes xtimer.h without xtimer_on_ztimer used, it will check that the timer frequency is compatible with xtimer.

I think that the hard dependency on xtimer_on_ztimer (or ztimer_xtimer_compat would also be fine) is missing for the waspmote-pro in Kconfig. That dependency is only required if xtimer is used.

This introduces a Kconfig file for boards that cannot reach a timer frequency compatible with xtimer. For those boards, in the case xtimer is pulled, ztimer is used instead (as backend) with a compatibility module.

Modelled boards: arduino-duemilanove arduino-leonardo arduino-mega2560 arduino-nano arduino-uno atmega1284p atmega256rfr2-xpro atmega328p-xplained-mini atmega328p atxmega-a1-xplained atxmega-a1u-xpro atxmega-a3bu-xplained avr-rss2 derfmega128 derfmega256 mega-xplained microduino-corerf zigduino

The option list has been taken from https://code.google.com/archive/p/libfixmath/wikis/CompilationOptions.wiki. The defaults are the current ones.

MrKevinWeiss · 2021-11-23T07:27:14Z

Looks like everything is there, any objections?

maribu · 2021-11-23T08:24:35Z

Phew. It would have been a pity if that had to go another round just because yet another merge conflict ...

leandrolanzieri · 2021-11-23T08:26:15Z

Thanks everyone !

MrKevinWeiss · 2021-11-26T07:27:49Z

drivers/at24mac/Kconfig

 config MODULE_AT24MAC
-    bool "AT24MAC unique ID chip"
+    bool
+    prompt "AT24MAC unique ID chip" if !(MODULE_EUI_PROVIDER && HAVE_AT24MAC)


It seems for the same54-xpro, MODULE_MTD would also bring in MODULE_AT24MAC

leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Platform: AVR Platform: This PR/issue effects AVR-based platforms labels Oct 1, 2021

leandrolanzieri requested review from maribu, MrKevinWeiss and fjmolinas October 1, 2021 11:33

leandrolanzieri requested review from cgundogan, jia200x and kaspar030 as code owners October 1, 2021 11:33

github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: sys Area: System labels Oct 1, 2021

leandrolanzieri mentioned this pull request Oct 1, 2021

[Tracking]: modeling dependencies in Kconfig #16875

Closed

maribu reviewed Oct 1, 2021

View reviewed changes

cpu/atmega_common/periph/Kconfig Outdated Show resolved Hide resolved

cpu/atmega_common/periph/Kconfig Show resolved Hide resolved

drivers/at30tse75x/Kconfig Outdated Show resolved Hide resolved

leandrolanzieri requested a review from kYc0o as a code owner October 4, 2021 08:24

github-actions bot added the Area: doc Area: Documentation label Oct 4, 2021

maribu approved these changes Oct 5, 2021

View reviewed changes

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 14, 2021

leandrolanzieri force-pushed the pr/cpu/avr8/model_kconfig branch from 899b27f to 90a7996 Compare November 1, 2021 08:58

leandrolanzieri added 23 commits November 22, 2021 12:25

cpu: model atmega-based CPUs Kconfig

659d3f9

sys/cxx_ctor_guards: model Kconfig

45b6116

sys/stdio/kconfig: associate symbol to implementation

3854db3

makefile.include: add RIOTKCONFIG

39ebbfd

sys/{x,z}timer: add file to use ztimer when xtimer is present

5383278

This introduces a Kconfig file for boards that cannot reach a timer frequency compatible with xtimer. For those boards, in the case xtimer is pulled, ztimer is used instead (as backend) with a compatibility module.

boards/common/{atmega,atxmega,arduino-atmega}: model Kconfig

e5164ca

drivers/at24mac: add Kconfig feature

347fb25

drivers/bmx280: refactor Kconfig model

7c56300

drivers/at24mac/Kconfig: enable as EUI provider when present

e678919

driver/at30tse75x/Kconfig: enable as default sensor when present

0a19e58

.murdock: add subset of avr-boards for Kconfig test

3fc6d42

cpu/atmega_common: move PCINT documentation from boards

8456814

cpu/atxmega: fix dependency

92b7e5e

drivers/dfplayer: add no_strerror option to Kconfig

e525e23

tests/driver_ili9341: add NO_RIOT_IMAGE option to Kconfig

3bdbd67

drivers/periph_common: add RTC ms module to Kconfig

7036388

pkg/libfixmath: add compile options to Kconfig

584052e

The option list has been taken from https://code.google.com/archive/p/libfixmath/wikis/CompilationOptions.wiki. The defaults are the current ones.

sys/arduino: add pseudomodule for the arduino_pwm feature

6769101

pkg/qdsa: use pseudomodules to select implementation

37b0e30

sys/arduino/kconfig: do not imply arduino_pwm

27a62ef

pkg/nanocbor/kconfig: remove architecture dependency

5abe003

sys/shell/commands/sc_dfplayer: make cppcheck happy

43c567a

maribu merged commit 68e1d29 into RIOT-OS:master Nov 23, 2021

leandrolanzieri deleted the pr/cpu/avr8/model_kconfig branch November 23, 2021 08:26

MrKevinWeiss reviewed Nov 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu/avr8: model kconfig #16929

cpu/avr8: model kconfig #16929

leandrolanzieri commented Oct 1, 2021

maribu left a comment

fjmolinas commented Oct 5, 2021

maribu left a comment

benpicco commented Oct 15, 2021

leandrolanzieri commented Nov 1, 2021

MrKevinWeiss commented Nov 1, 2021

MrKevinWeiss commented Nov 1, 2021

leandrolanzieri commented Nov 1, 2021

maribu commented Nov 1, 2021

MrKevinWeiss commented Nov 23, 2021

maribu commented Nov 23, 2021

leandrolanzieri commented Nov 23, 2021

MrKevinWeiss Nov 26, 2021

cpu/avr8: model kconfig #16929

cpu/avr8: model kconfig #16929

Conversation

leandrolanzieri commented Oct 1, 2021

Contribution description

A note on driver modelling

Testing procedure

Issues/PRs references

maribu left a comment

Choose a reason for hiding this comment

fjmolinas commented Oct 5, 2021

maribu left a comment

Choose a reason for hiding this comment

benpicco commented Oct 15, 2021

leandrolanzieri commented Nov 1, 2021

MrKevinWeiss commented Nov 1, 2021

MrKevinWeiss commented Nov 1, 2021

leandrolanzieri commented Nov 1, 2021

maribu commented Nov 1, 2021

MrKevinWeiss commented Nov 23, 2021

maribu commented Nov 23, 2021

leandrolanzieri commented Nov 23, 2021

MrKevinWeiss Nov 26, 2021

Choose a reason for hiding this comment