Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/efm32: model kconfig #16912

Merged
merged 9 commits into from
Nov 18, 2021
Merged

cpu/efm32: model kconfig #16912

merged 9 commits into from
Nov 18, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This adds the Kconfig modules for efm32 and related boards. I added to the CI script one board with EFM32, one with EFR32 and one with EZR32.

Testing procedure

  • Green CI
  • You should be able to use the applications that already have a Kconfig configuration with TEST_KCONFIG=1.

Issues/PRs references

#16875

@leandrolanzieri leandrolanzieri added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 29, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Sep 29, 2021
Closed
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Sep 29, 2021
fjmolinas
fjmolinas reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good, haven't looked at menuconfig yet..

cpu/efm32/Makefile.features Outdated
# Add efm32 configurations after including cortexm_common so efm32 takes precendence
# This configuration enables modules that are only available when using Kconfig
# module modelling
ifeq (1, $(TEST_KCONFIG))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ifeq (1, $(TEST_KCONFIG))
ifeq (1,$(TEST_KCONFIG))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pkg/cmsis-dsp/Makefile
Comment on lines +8 to +9
# include makefiles utils tools
include $(RIOTMAKE)/utils/strings.mk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this available early on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was returning empty string, so I'm guessing it's not.

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 5, 2021
@fjmolinas
Copy link
Contributor

please rebase and squash @leandrolanzieri

@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/efm32/model_kconfig branch 2 times, most recently from d989a82 to 1e3d116 Compare October 6, 2021 12:31
@github-actions github-actions bot added the Area: examples Area: Example Applications label Oct 6, 2021
@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/efm32/model_kconfig branch from 1e3d116 to a9af4cc Compare October 6, 2021 13:17
@github-actions github-actions bot removed the Area: examples Area: Example Applications label Oct 6, 2021
@fjmolinas
Copy link
Contributor

This one needs a rebase @leandrolanzieri !

@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/efm32/model_kconfig branch from a9af4cc to 17e6da0 Compare November 2, 2021 10:42
@leandrolanzieri
Copy link
Contributor Author

Done!

fjmolinas
fjmolinas reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, will probably need another rebase for the static tests though.

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 2, 2021
@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/efm32/model_kconfig branch from 6d3de2e to 0d9bf24 Compare November 11, 2021 15:47
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: tests Area: tests and testing framework labels Nov 12, 2021
@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 17, 2021
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 17, 2021
@leandrolanzieri leandrolanzieri force-pushed the pr/cpu/efm32/model_kconfig branch from 052cf95 to 6a1340d Compare November 18, 2021 08:00
@leandrolanzieri
Copy link
Contributor Author

Ok this is squashed now

@fjmolinas
Copy link
Contributor

GO!

@fjmolinas fjmolinas merged commit d573401 into RIOT-OS:master Nov 18, 2021
@leandrolanzieri leandrolanzieri deleted the pr/cpu/efm32/model_kconfig branch November 18, 2021 10:33
@leandrolanzieri
Copy link
Contributor Author

Thanks for the review!

@leandrolanzieri leandrolanzieri mentioned this pull request Dec 8, 2021
Merged
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
4 participants
@leandrolanzieri @fjmolinas @kaspar030 @MrKevinWeiss