Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated includes introduced in #15902 #16798

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

hugueslarrive
Copy link
Contributor

Contribution description

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform labels Sep 2, 2021
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2021
fjmolinas
fjmolinas previously approved these changes Sep 2, 2021
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks for the catch!

@fjmolinas fjmolinas dismissed their stale review September 2, 2021 07:29

just noticed the commit message

@fjmolinas fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2021
@fjmolinas
Copy link
Contributor

@hugueslarrive can you modify the commit message according to our coding conventions https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions, I'll re-ACK and trigger CI after.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2021
@dylad dylad added this to the Release 2021.10 milestone Sep 2, 2021
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad merged commit 6e1bf61 into RIOT-OS:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants