Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

congure_mock: add capability to provide actual methods #16133

Merged
merged 1 commit into from
May 4, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 3, 2021

Contribution description

This extends the congure_mock so that actual congure method drivers can be added, in case the test needs some actual functionality.

Testing procedure

No tests are provided for the new functionality (it will be used in a later PR). tests/congure_test should still compile and pass.

$ BOARD=iotlab-m3 make -C tests/congure_test/ --no-print-directory -j flash test
Building application "tests_congure_test" for "iotlab-m3" with MCU "stm32".

[…]
   text	   data	    bss	    dec	    hex	filename
  18300	    132	   2536	  20968	   51e8	/home/mlenders/Repositories/RIOT-OS/RIOT/tests/congure_test/bin/iotlab-m3/tests_congure_test.elf
For full programmer output add PROGRAMMER_QUIET=0 or QUIET=0 to the make command line.
 ✓ Flashing done! (programmer: 'openocd' - duration: 2.01s)
......................................
----------------------------------------------------------------------
Ran 38 tests in 18.911s

OK

Issues/PRs references

None, but part of the larger congestion control effort.

PR dependency graph

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: sys Area: System labels Mar 3, 2021
@miri64 miri64 added this to the Release 2021.04 milestone Mar 3, 2021
@miri64 miri64 requested review from MrKevinWeiss and fjmolinas March 3, 2021 11:56
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tests are green, @miri64 is maintaining this so trusting this is needed.

@fjmolinas fjmolinas merged commit 3cb3b5a into RIOT-OS:master May 4, 2021
@miri64 miri64 deleted the congure_mock/enh/real-methods branch May 4, 2021 09:17
@miri64
Copy link
Member Author

miri64 commented May 4, 2021

ACK, tests are green, @miri64 is maintaining this so trusting this is needed.

It is used in #16156 and its follow-ups ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants