cpu/stm32g0: add basic support + add nucleo-g070rb board #14163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Platform: ARM
aabadie
requested review from
DipSwitch,
kaspar030,
MrKevinWeiss,
roberthartung and
vincent-d
as code owners
aabadie
requested review from
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
aabadie
added
the
CI: ready for build
aabadie
added
the
State: waiting for other PR
aabadie
force-pushed
the
pr/cpu/stm32g0
branch
4 times, most recently
from
8530feb to
e3b8954
Compare
kaspar030
added
CI: ready for build
aabadie
removed
the
State: waiting for other PR
|
rebased |
|
I found the solution for the EXTI configuration and now gpio_irq is working: tests/buttons behaves as expected |
benpicco
approved these changes
Jul 21, 2020
benpicco
reviewed
Jul 21, 2020
cpu/stm32/include/vendor/stm32g0xx.h
Outdated
Comment on lines
137
to
141
| typedef enum | ||
| { | ||
| SUCCESS = 0, | ||
| ERROR = !SUCCESS | ||
| } ErrorStatus; |
There was a problem hiding this comment.
I would say patch MQTTClient.h, but that's from an external source too 😕
|
Needs a rebase 😃 |
|
Now that #14152 is merged, I adapted this one accordingly. If Murdock is green, it should be good. |
|
|
It will work without any change because there's an ifdef for all STM32 (added in #14152). |
|
Please squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds an initial support for the stm32g0 family of CPUs. The nucleo-g070rb board is also added so people can test.
Only a few peripheral APIs are supported for the moment: gpio (no IRQ!), timer, uart, i2c, spi, flashpage. The riotboot feature is also available.
Important features that are missing: gpio_irq, rtc
Note that even if the clock configuration is quite similar to L4/WB families, I decided to add a new file for g0, to avoid even more ifdef there.The clock configuration is shared with the G4 family because they are very similar.
The clock configuration defined in the board was also adapted to allow choosing between HSE, HSI or PLL (itself clocked by either HSI or HSE) as system source clock. The PLL clock source is the default.
Since there's no HSE available on the nucleo-g070rb, the default PLL clock source is HSI (
@16MHz). The core clock is configured to be 64MHz.Testing procedure
./dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . nucleo-g070rb --jobs=4and check the results are okThe script reported these failures:
Most of them are related to network setup or root priviledge missing.
tests/pkg_libfixmath_unittests,tests/driver_grove_ledbarandtests/driver_my9221are problematic but I haven't looked at them in detail for the moment.Issues/PRs references
depends on #14166