Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/rn2xx3 : Expose Configurations to Kconfig #13952

Merged
merged 3 commits into from
May 22, 2020
Merged

drivers/rn2xx3 : Expose Configurations to Kconfig #13952

merged 3 commits into from
May 22, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Apr 26, 2020

Contribution description

This PR exposes compile configurations in RN2XX3 Network Device driver to Kconfig.

Testing procedure

New macro was introduced in tests/driver_rn2xx3/main.c for testing.

#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=(5000U)
RN2XX3 device driver test
RN2XX3 initialization failed

Usage with CFLAGS

/tests/driver_rn2xx3/Makefile

CFLAGS += -DCONFIG_RN2XX3_DEFAULT_SLEEP=7000

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=7000
RN2XX3 device driver test
RN2XX3 initialization failed

Usage with Kconfig

/tests/driver_rn2xx3/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-199-gd936bb-Kconfig_rn2xx3)
CONFIG_RN2XX3_DEFAULT_SLEEP=10000
RN2XX3 device driver test
RN2XX3 initialization failed
Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri

@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 27, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 27, 2020
leandrolanzieri
leandrolanzieri reviewed Apr 27, 2020
View reviewed changes
drivers/rn2xx3/Kconfig Outdated Show resolved Hide resolved
drivers/rn2xx3/Kconfig Show resolved Hide resolved
drivers/rn2xx3/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 27, 2020
Open
71 tasks
leandrolanzieri
leandrolanzieri reviewed May 22, 2020
View reviewed changes
Kconfig.macros Outdated Show resolved Hide resolved
akshaim and others added 2 commits May 22, 2020 15:52
@akshaim
drivers/rn2xx3.h : Add CONFIG_
7d679c7 
Add CONFIG_ prefix to RN2XX3_DEFAULT_SLEEP
@akshaim @leandrolanzieri
drivers/rn2xx3 : Expose to Kconfig
5699b24 
Expose configurations to Kconfig

Co-Authored-By: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
leandrolanzieri
leandrolanzieri reviewed May 22, 2020
View reviewed changes
Kconfig Outdated Show resolved Hide resolved
@akshaim @leandrolanzieri
(RIOTBASE) : Kconfig macro definitions
26c0dab 
Create new file for Kconfig Macro definitions

Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 22, 2020
leandrolanzieri
leandrolanzieri approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested building and changing the sleep value, and it works fine. ACK.

@leandrolanzieri leandrolanzieri merged commit d62cf18 into RIOT-OS:master May 22, 2020
@akshaim akshaim deleted the Kconfig_rn2xx3 branch May 23, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri