Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbus/cdc/ecm: Expose configurations to Kconfig #13839

Merged
merged 5 commits into from
Apr 21, 2020
Merged

usbus/cdc/ecm: Expose configurations to Kconfig #13839

merged 5 commits into from
Apr 21, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

Similarly to #13375, this exposes the USBUS CDC ECM module configuration parameters to Kconfig, and moves the macros to CONFIG_ namespace.

I added a switch on the Kconfig file to enable configuring upstream and downstream speeds individually, or via a 'throughput' option (similar to the macros).

Testing procedure

Run tests/usbus_cdc_ecm, it should be working and should be configurable via menuconfig.

Issues/PRs references

Part of #12888

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Apr 8, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 8, 2020
Open
71 tasks
@bergzand bergzand self-assigned this Apr 14, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Apr 16, 2020
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 16, 2020
@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 16, 2020
bergzand
bergzand approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

@bergzand bergzand merged commit 40cb065 into RIOT-OS:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@bergzand bergzand

Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @bergzand @cgundogan