Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kconfig: Expose gnrc/ipv6 configurations #13066

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

PeterKietzmann
Copy link
Member

Contribution description

This PR moves the configuration macros of gnrc_ipv6 found here to the CONFIG_ namespace, and exposes them to Kconfig.

As agreed offline with @leandrolanzieri I did not include the thread stacksize and priority parameters because these should be defined by the platform, if not changed manually. We might need a better solution to this in future.

In the configuration header file, some defines relate to the FIB & RPL (see here). I think this should changed together with adding "GNRC IPv6 NIB compile configurations" as proposed in #12888.

Testing procedure

  • examples/gnrc_networking should still work as usual.
  • You should be able to configure the module's parameters via make menuconfig in the test application.

Issues/PRs references

Part of #12888

@PeterKietzmann PeterKietzmann added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT TF: Config Marks issues and PRs related to the work of the Configuration Task Force labels Jan 9, 2020
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Just two details on the prompts. Please address them and squash directly.

sys/net/gnrc/network_layer/ipv6/Kconfig Outdated Show resolved Hide resolved
sys/net/gnrc/network_layer/ipv6/Kconfig Outdated Show resolved Hide resolved
@PeterKietzmann
Copy link
Member Author

Thanks @leandrolanzieri, addressed your comment.

@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 10, 2020
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterKietzmann thanks! ACK

@leandrolanzieri leandrolanzieri merged commit 7463543 into RIOT-OS:master Jan 10, 2020
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants