net/nanocoap: fix issues reported by scan-build #12584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Area: network
benpicco
approved these changes
Oct 27, 2019
miri64
requested changes
Oct 27, 2019
sys/include/net/nanocoap.h
Outdated
| @@ -585,7 +585,7 @@ ssize_t coap_opt_get_next(const coap_pkt_t *pkt, coap_optpos_t *opt, | |||
| * @param[out] value start of the option value | |||
| * | |||
| * @return length of option; 0 if the option exists but is empty | |||
| * @return -ENOENT if option not found | |||
| * @return -ENOENT if option not found or option cannot be parsed | |||
There was a problem hiding this comment.
Shouldn't this rather be a distinct error code? E.g. -EINVAL?
There was a problem hiding this comment.
Good idea. Changed.
|
Please squash. |
This fixes a potential use of uninitialized len in subsequent function calls. This was reported by scan-build
aabadie
force-pushed
the
pr/net/nanocoap_scan_build
branch
from
76879c7 to
8b06560
Compare
|
squashed (better late than never ;) ) |
|
ACK upholds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is fixing all issues reported by scan-build in nanocoap.c.
Testing procedure
Run
TOOLCHAIN=llvm make -C examples/nanocoap_server/ scan-buildOn master, several warning are raised in nanocoap.c. With this PR, all are fixed.
Test the
examples/nanocoap_serverand verify it still worksIssues/PRs references
Tick one item in #11852